Modify ↓

Opened 8 years ago

Closed 8 years ago

#15110 closed enhancement (fixed)

[patch] Disable audio actions when no audio is present

Reported by: bafonins Owned by: team
Priority: normal Milestone: 17.08
Component: Core audio Version:
Keywords: Cc:

Description

In some cases using the audio actions can cause JOSM to crash. This patch solves this issue by disabling these actions if there is no audio present.

Attachments (1)

audio-disable.patch​ (12.5 KB ) - added by bafonins 8 years ago.

Download all attachments as: .zip

Change History (4)

by bafonins, 8 years ago

Attachment: audio-disable.patch​ added

comment:1 by Don-vip, 8 years ago

Component: Core → Core audio
Keywords: audio removed
Milestone: → 17.08
Type: defect → enhancement

comment:2 by Don-vip, 8 years ago

Thanks! I'm going to merge the patch modified as follows:

  • keep newlines at end of files
  • follow checkstyle conventions
  • simplify base audio action, as the listening to layer changes is already implemented by JosmAction
  • drop change of API to use Optional, not needed

comment:3 by Don-vip, 8 years ago

Resolution: → fixed
Status: new → closed

In 12565/josm:

fix #15110 - Disable audio actions when no audio is present (patch by bafonins, modified)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.