Opened 5 years ago

Closed 5 years ago

#15110 closed enhancement (fixed)

[patch] Disable audio actions when no audio is present

Reported by: bafonins Owned by: team
Priority: normal Milestone: 17.08
Component: Core audio Version:
Keywords: Cc:


In some cases using the audio actions can cause JOSM to crash. This patch solves this issue by disabling these actions if there is no audio present.

Attachments (1)

audio-disable.patch (12.5 KB) - added by bafonins 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by bafonins

Attachment: audio-disable.patch added

comment:1 Changed 5 years ago by Don-vip

Component: CoreCore audio
Keywords: audio removed
Milestone: 17.08
Type: defectenhancement

comment:2 Changed 5 years ago by Don-vip

Thanks! I'm going to merge the patch modified as follows:

  • keep newlines at end of files
  • follow checkstyle conventions
  • simplify base audio action, as the listening to layer changes is already implemented by JosmAction
  • drop change of API to use Optional, not needed

comment:3 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 12565/josm:

fix #15110 - Disable audio actions when no audio is present (patch by bafonins, modified)

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.