Opened 7 years ago
Closed 7 years ago
#14950 closed enhancement (fixed)
validator doesn't show error if way isn't tagged properly
Reported by: | muzirian | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 17.06 |
Component: | Core validator | Version: | |
Keywords: | template_report | Cc: |
Description
What steps will reproduce the problem?
- Draw a way
- Add access=private tag
- run validator
What is the expected result?
The validator should inform that the way isn't defined properly.
What happens instead?
Shows no errors or warnings
Please provide any additional information below. Attach a screenshot if possible.
URL:http://josm.openstreetmap.de/svn/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2017-05-29 16:19:58 +0200 (Mon, 29 May 2017) Build-Date:2017-05-29 14:25:03 Revision:12275 Relative:URL: ^/trunk Identification: JOSM/1.5 (12275 en) Mac OS X 10.12.3 OS Build number: Mac OS X 10.12.3 (16D30) Memory Usage: 625 MB / 910 MB (130 MB allocated, but free) Java version: 1.8.0_131-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM Screen: Display 69991240 2560x1440 Maximum Screen Size: 2560x1440 VM arguments: [-Djava.library.path=/Applications/JOSM.app/Contents/MacOS, -DLibraryDirectory=${HOME}/Library, -DDocumentsDirectory=${HOME}/Documents, -DApplicationSupportDirectory=${HOME}/Library/Application Support, -DCachesDirectory=${HOME}/Library/Caches, -DSandboxEnabled=false, -Dapple.laf.useScreenMenuBar=true, -Dcom.apple.macos.use-file-dialog-packages=true, -Dcom.apple.macos.useScreenMenuBar=true, -Dcom.apple.mrj.application.apple.menu.about.name=JOSM, -Dcom.apple.smallTabs=true] Dataset consistency test: No problems found Plugins: + FastDraw (33182) + ImproveWay (12) + Mapillary (v1.5.3) + OpenStreetCam (81) + apache-commons (32994) + apache-http (32699) + auto_tools (1494971731) + buildings_tools (33004) + download_along (32946) + imagery_offset_db (33316) + reverter (33088) + terracer (33088) + tofix (338) + utilsplugin2 (33328) Map paint styles: + https://josm.openstreetmap.de/josmfile?page=Styles/HiDPISupport&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1 Last errors/warnings: - W: java.io.IOException: Attribution is not loaded yet - W: java.io.IOException: Attribution is not loaded yet - W: java.io.IOException: Attribution is not loaded yet - W: java.io.IOException: Attribution is not loaded yet - W: java.io.IOException: Attribution is not loaded yet - W: java.io.IOException: Attribution is not loaded yet - W: java.io.IOException: Attribution is not loaded yet - W: java.io.IOException: Attribution is not loaded yet - W: java.io.IOException: Attribution is not loaded yet - W: java.io.IOException: Attribution is not loaded yet
Attachments (0)
Change History (6)
comment:1 by , 7 years ago
Milestone: | → 17.06 |
---|---|
Type: | defect → enhancement |
comment:3 by , 7 years ago
Thanks for the quick response :)
Just found, like the access tag, other tags also gives the same result, for example i tried, bridge=yes, car=no. So may be we should expand it fix all these kinda scenarios?
comment:4 by , 7 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:5 by , 7 years ago
We can't test for every possible tagging mistake. That would make the validator too slow. The validator should be limited to real problems, i.e. tagging mistakes which occour often.
Is that the case for car=no and bridge=yes?
comment:6 by , 7 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Only 1 object with only car=no http://overpass-turbo.eu/s/pUz
only bridge=yes on ways already has a warning
bridge=yes on nodes is wrong anyway independent on the other tags and has a warning already too.
Seems to appear relatively often: http://overpass-turbo.eu/s/pT6