Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#14861 closed enhancement (fixed)

add a fix for the "Route should start and end with a stop_position" error

Reported by: giackserva Owned by: giackserva
Priority: normal Milestone:
Component: Plugin pt_assistant Version:
Keywords: gsoc_pt_assistant Cc:

Description

Currently the problem has no fix. It could be useful to have the relation dialog opened as fix.

Attachments (0)

Change History (8)

comment:1 Changed 3 years ago by giackserva

Resolution: fixed
Status: assignedclosed

comment:2 Changed 3 years ago by Don-vip

why did you close your own ticket?

comment:3 Changed 3 years ago by giackserva

Because I fixed it, shouldn't I close it after fixing it? I'm making tickets while implementing new stuff for the GSoC. Let me know if I'm supposed to do differently

Last edited 3 years ago by giackserva (previous) (diff)

comment:4 Changed 3 years ago by Don-vip

OK sorry I didn't understand. To make changes easier to follow, it is good practice to add a link to the changeset where you fixed the ticket, using the syntax [o33347]. Example: fixed in [o33347]. If there are several commits you can use the syntax [o33347:33349]. Example: fixed in [o33347:33349].

comment:5 Changed 3 years ago by giackserva

Ok, I didn't know that. I will do this from now on.
I noticed that on the GitHub mirror of the repository, your profile is connected to your SVN one so that it appears like your GitHub account made the commit. How did you do that?

comment:6 Changed 3 years ago by Don-vip

Go to https://github.com/settings/emails and add the following e-mail address: giackserva@b9d5c4c9-76e1-0310-9c85-f3177eceb1e4

comment:7 Changed 3 years ago by giackserva

it works! thank you!

comment:8 Changed 3 years ago by Don-vip

You're welcome :) Thank you for joining the GSoC program, it is always a pleasure to see students interested in JOSM development. Feel free to ask for help or core changes if needed, either on the josm-dev mailing list or the bug tracker itself.

We have two great tools at your disposal for the code quality:

  • jenkins which runs the unit tests and performs Checkstyle/Findbugs analysis every night. So don't be afraid to add more unit tests, you will see the results here.
  • sonar which performs code analysis in greater detail, also every night. All plugins are in a single project, but you can find pt_assistant details here.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain giackserva.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.