#14840 closed enhancement (fixed)
[patch] Add separation borders to search screen
Reported by: | jidanni | Owned by: | bafonins |
---|---|---|---|
Priority: | minor | Milestone: | 17.06 |
Component: | Core | Version: | |
Keywords: | search | Cc: | bafonins |
Description (last modified by )
Attachments (11)
Change History (28)
Changed 6 years ago by
Attachment: | josmSearch.jpg added |
---|
comment:1 Changed 6 years ago by
Description: | modified (diff) |
---|---|
Keywords: | search added |
Changed 6 years ago by
Attachment: | search-old.jpg added |
---|
Changed 6 years ago by
Attachment: | search-expert-new.jpg added |
---|
Changed 6 years ago by
Attachment: | search-new.jpg added |
---|
comment:2 Changed 6 years ago by
comment:3 follow-up: 6 Changed 6 years ago by
Missing the patch file.
"Search examples" is wrong, as only some are examples, most are ready to use clicks.
comment:4 Changed 6 years ago by
Summary: | Add separation borders to search screen → [patch] Add separation borders to search screen |
---|
comment:5 Changed 6 years ago by
Your patch contains lot of stuff which should not be there including reverts of changes done recently.
Changed 6 years ago by
Attachment: | ticket14840_2.patch added |
---|
Merged supplied patch with the latest release of JOSM.
comment:6 Changed 6 years ago by
Cc: | bafonins added |
---|
Replying to stoecker:
"Search examples" is wrong, as only some are examples, most are ready to use clicks.
Examples that are useful are the best ones ;-).
I think "hints" is a better word. Or "syntax" (but it is not a real syntax definition, so "hints on search syntax"?)
I can do the merging next week (after I figured out the backspace-bug)
Changed 6 years ago by
Attachment: | ticket14840_3.patch added |
---|
Resolved minor ant-checkstyle warnings
Changed 6 years ago by
Attachment: | 14840-v4.patch added |
---|
Just for convenience, merged two previous patched into one
comment:9 Changed 6 years ago by
Milestone: | → 17.06 |
---|
comment:10 Changed 6 years ago by
Priority: | trivial → minor |
---|
Changed 6 years ago by
comment:12 Changed 6 years ago by
comment:13 Changed 6 years ago by
Wouldn't "Syntax" be a better name for the block "Search Options"?
comment:14 Changed 6 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:15 Changed 6 years ago by
Owner: | changed from team to bafonins |
---|---|
Status: | reopened → new |
Changed 6 years ago by
Attachment: | 14840-alignment-fix.patch added |
---|
Sorry for that, this should fix the issue with the alignment
Hi!
Spent some time on it, would like to show the results.



Here is the old version, view in the expert mode :
Here is the new version, again in the expert mode :
And finally, the regular mode :
In my opinion, looks more compact and structured. Any suggestions?