[patch] Add separation borders to search screen

[jidanni]

Please add some borders as show below:

[bafonins]

Hi!

Spent some time on it, would like to show the results.
Here is the old version, view in the expert mode :

Here is the new version, again in the expert mode :

And finally, the regular mode :

In my opinion, looks more compact and structured. Any suggestions?

[stoecker]

Missing the patch file.

"Search examples" is wrong, as only some are examples, most are ready to use clicks.

[bafonins]

Refactored Search Dialog

[stoecker]

Your patch contains lot of stuff which should not be there including reverts of changes done recently.

[bafonins]

Merged supplied patch with the latest release of JOSM.

[michael2402]

Replying to stoecker:

"Search examples" is wrong, as only some are examples, most are ready to use clicks.

Examples that are useful are the best ones ;-).

I think "hints" is a better word. Or "syntax" (but it is not a real syntax definition, so "hints on search syntax"?)

I can do the merging next week (after I figured out the backspace-bug)

[bafonins]

Resolved minor ant-checkstyle warnings

[jidanni]

Nice design.

[bafonins]

Just for convenience, merged two previous patched into one

[michael2402]

In 12333/josm:

Fix #14840: Add separation borders to search dialog. Patch by bafonins

[Don-vip]

Nice, thanks! :)

[Klumbumbus]

In localized JOSM it looks a bit strange. Could the text of the three blocks on the left made left aligned?

[Klumbumbus]

Wouldn't "Syntax" be a better name for the block "Search Options"?

[bafonins]

Fixed alignment

[bafonins]

Sorry for that, this should fix the issue with the alignment

[michael2402]

In 12345/josm:

Apply #14840: Fix alignment in search dialog. Patch by bafonins

[jidanni]

Thanks.