Modify

Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#14766 closed defect (fixed)

Self-intersection check not working for multipolygons

Reported by: popov@… Owned by: team
Priority: normal Milestone: 17.10
Component: Core validator Version: tested
Keywords: self intersection check multipolygon relation Cc: stoecker

Description

What steps will reproduce the problem?

  1. Open https://www.openstreetmap.org/relation/4056364 in JOSM
  2. Try to check for self-intersection

What is the expected result?

An error for self-intersection

What happens instead?

Errors not found

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-05-02 23:28:33 +0200 (Tue, 02 May 2017)
Build-Date:2017-05-02 21:34:40
Revision:12039
Relative:URL: ^/trunk

Identification: JOSM/1.5 (12039 ru) Linux Ubuntu 14.04.5 LTS
Memory Usage: 359 MB / 1707 MB (68 MB allocated, but free)
Java version: 1.8.0_101-b13, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080, :0.1 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ ejml (32680)
+ ext_tools (33004)
+ geojson (52)
+ geotools (33042)
+ jts (32699)
+ poly (33004)
+ print (33260)
+ utilsplugin2 (33212)

Map paint styles:
- ${HOME}/work/josm/potlatch2.mapcss

Validator rules:
+ https://raw.githubusercontent.com/zetx16/Josm-HnumbValidator/master/ru-housenumber.validator.mapcss

Last errors/warnings:
- W: java.net.SocketException: Connection reset
- W: Конфликт в данных - <html>Это отношение было изменено за пределами редактора.<br>Невозможно применить ваши изменения и продолжить правку.<br><br>Вы хотите создать конфликт и закрыть редактор?</html>
- W: Несохранённые изменения - <html>Отношение было изменено.<br><br>Вы хотите сохранить изменения?</html>
- W: javax.net.ssl.SSLHandshakeException: Remote host closed connection during handshake. Причина: java.io.EOFException: SSL peer shut down incorrectly
- E: javax.net.ssl.SSLHandshakeException: Remote host closed connection during handshake. Причина: java.io.EOFException: SSL peer shut down incorrectly
- E: org.openstreetmap.josm.io.OsmTransferException: Не удается соединиться с сервером OSM. Пожалуйста, проверьте Ваше интернет-соединение.. Причина: javax.net.ssl.SSLHandshakeException: Remote host closed connection during handshake. Причина: java.io.EOFException: SSL peer shut down incorrectly
- E: Ошибка Ввода-вывода - <html>Не удалось скачать данные с <br>«https://api.openstreetmap.org/api/0.6/map?bbox=136.89617,50.66365,136.89829,50.66569» или отправить их туда<br>из-за проблеме при передаче данных.<br>Подробности (без перевода): Remote host closed connection during handshake</html>
- W: java.net.SocketException: Socket closed
- W: Already here java.io.EOFException: SSL peer shut down incorrectly
- E: java.net.SocketException: Socket closed

Attachments (1)

14766.osm (36.2 KB ) - added by Don-vip 6 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by Don-vip, 7 years ago

Component: CoreCore validator

comment:2 by Don-vip, 6 years ago

Cc: stoecker added
Keywords: multipolygon relation added
Summary: Self-intersection check not working for some caseSelf-intersection check not working for multipolygons

by Don-vip, 6 years ago

Attachment: 14766.osm added

comment:3 by GerdP, 6 years ago

I'll have a look at this. It seems I've missed this obvious case, means, there is no code to detect it.

Last edited 6 years ago by GerdP (previous) (diff)

comment:4 by GerdP, 6 years ago

Resolution: fixed
Status: newclosed

In 12941/josm:

fix #14766 - Self-intersection check not working for multipolygons

The test failed to detect self-intersecting rings formed by multiple ways.
This is now handled. Single self-intersecting ways are still only handled by SelfIntersectingWay to avoind duplicate warnings for the same issue.

comment:5 by Klumbumbus, 6 years ago

Milestone: 17.10

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.