Colorfulness adjustment

[anonymous]

What steps will reproduce the problem?

1. Imported a raster imagery layer
2. Adjusted Colorfulness amount
3. Error popped up

What is the expected result?

Colorfulness changes

What happens instead?

Error popped up

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-05-02 23:28:33 +0200 (Tue, 02 May 2017)
Build-Date:2017-05-02 21:34:40
Revision:12039
Relative:URL: ^/trunk

Identification: JOSM/1.5 (12039 en) Linux Ubuntu 16.04.2 LTS
Memory Usage: 2346 MB / 14299 MB (1184 MB allocated, but free)
Java version: 1.8.0_121-8u121-b13-0ubuntu1.16.04.2-b13, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 5120x1440, :0.1 2560x1440
Maximum Screen Size: 5120x1440
Java package: openjdk-8-jre:amd64-8u121-b13-0ubuntu1.16.04.2
Dataset consistency test: No problems found

Plugins:
+ print (33260)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Highway_Nodes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Last errors/warnings:
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- E: Handled by bug report queue: java.lang.IllegalArgumentException: Unknown image type 0

OSM API: http://fusion-osm-dev.torcrobotics.net/api


=== REPORTED CRASH DATA ===
MapView#paintLayer:
 - layer: WMSLayer [info=ImageryInfo{name='fusion-maps-dev.torcrobotics.net: lidar_10cm_merge', countryCode='', url='http://fusion-maps-dev.torcrobotics.net:80/geoserver/ows?SERVICE=WMS&FORMAT=image/png&TRANSPARENT=TRUE&VERSION=1.1.1&SERVICE=WMS&REQUEST=GetMap&LAYERS=fusion.q2:lidar_10cm_merge&STYLES=&SRS={proj}&WIDTH={width}&HEIGHT={height}&BBOX={bbox}', imageryType=WMS}]

Warning issued by: MapView#paintLayer

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (19) of main
java.lang.IllegalArgumentException: Unknown image type 0
	at java.awt.image.BufferedImage.<init>(BufferedImage.java:501)
	at org.openstreetmap.josm.gui.layer.imagery.ColorfulFilter.createCompatibleDestImage(ColorfulFilter.java:124)
	at org.openstreetmap.josm.gui.layer.imagery.ColorfulFilter.lambda$filter$0(ColorfulFilter.java:38)
	at java.util.Optional.orElseGet(Optional.java:267)
	at org.openstreetmap.josm.gui.layer.imagery.ColorfulFilter.filter(ColorfulFilter.java:38)
	at org.openstreetmap.josm.gui.layer.imagery.ColorfulImageProcessor.process(ColorfulImageProcessor.java:47)
	at org.openstreetmap.josm.gui.layer.ImageryLayer.applyImageProcessors(ImageryLayer.java:334)
	at org.openstreetmap.josm.gui.layer.AbstractTileSourceLayer.lambda$paintTileImages$2(AbstractTileSourceLayer.java:997)
	at org.openstreetmap.josm.gui.layer.AbstractTileSourceLayer$TileSet.visitTilePosition(AbstractTileSourceLayer.java:1281)
	at org.openstreetmap.josm.gui.layer.AbstractTileSourceLayer$TileSet.lambda$visitTiles$5(AbstractTileSourceLayer.java:1273)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at java.util.stream.IntPipeline$4$1.accept(IntPipeline.java:250)
	at java.util.stream.Streams$RangeIntSpliterator.forEachRemaining(Streams.java:110)
	at java.util.Spliterator$OfInt.forEachRemaining(Spliterator.java:693)
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
	at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418)
	at java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:270)
	at java.util.stream.IntPipeline$4$1.accept(IntPipeline.java:250)
	at java.util.stream.Streams$RangeIntSpliterator.forEachRemaining(Streams.java:110)
	at java.util.Spliterator$OfInt.forEachRemaining(Spliterator.java:693)
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
	at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
	at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
	at java.util.concurrent.ForkJoinTask.doInvoke(ForkJoinTask.java:401)
	at java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:734)
	at java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:160)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:174)
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
	at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418)
	at org.openstreetmap.josm.gui.layer.AbstractTileSourceLayer$TileSet.visitTiles(AbstractTileSourceLayer.java:1273)
	at org.openstreetmap.josm.gui.layer.AbstractTileSourceLayer.paintTileImages(AbstractTileSourceLayer.java:977)
	at org.openstreetmap.josm.gui.layer.AbstractTileSourceLayer.drawInViewArea(AbstractTileSourceLayer.java:1466)
	at org.openstreetmap.josm.gui.layer.AbstractTileSourceLayer.access$2600(AbstractTileSourceLayer.java:131)
	at org.openstreetmap.josm.gui.layer.AbstractTileSourceLayer$TileSourcePainter.doPaint(AbstractTileSourceLayer.java:1824)
	at org.openstreetmap.josm.gui.layer.AbstractTileSourceLayer$TileSourcePainter.paint(AbstractTileSourceLayer.java:1819)
	at org.openstreetmap.josm.gui.MapView.paintLayer(MapView.java:458)
	at org.openstreetmap.josm.gui.MapView.drawMapContent(MapView.java:549)
	at org.openstreetmap.josm.gui.MapView.paint(MapView.java:480)
	at javax.swing.JComponent.paintChildren(JComponent.java:889)
	at javax.swing.JComponent.paint(JComponent.java:1065)
	at javax.swing.JComponent.paintToOffscreen(JComponent.java:5210)
	at javax.swing.BufferStrategyPaintManager.paint(BufferStrategyPaintManager.java:290)
	at javax.swing.RepaintManager.paint(RepaintManager.java:1272)
	at javax.swing.JComponent._paintImmediately(JComponent.java:5158)
	at javax.swing.JComponent.paintImmediately(JComponent.java:4969)
	at javax.swing.RepaintManager$4.run(RepaintManager.java:831)
	at javax.swing.RepaintManager$4.run(RepaintManager.java:814)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
	at javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:814)
	at javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:789)
	at javax.swing.RepaintManager.prePaintDirtyRegions(RepaintManager.java:738)
	at javax.swing.RepaintManager.access$1200(RepaintManager.java:64)
	at javax.swing.RepaintManager$ProcessingRunnable.run(RepaintManager.java:1732)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:756)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:726)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

[erichahn525@…]

Colorfulness error

[Don-vip]

can you please tell us what imagery layer did you add, and at which location exactly? (lat/lon coordinates)

[michael2402]

In 12102/josm:

Fix #14763: Do not apply colorful filter op if source image is of custom type.

[michael2402]

I fixed this issue. Filters cannot be applied to images with a unknown color type. The fix for now is to not apply the filter at all. We could work around this, but it would require a lot of work and filtering would be much slower than it is now.