Context Navigation

Modify ↓

#14754 closed defect (fixed)

avoid silent failure on malformed changeset .osm file

Reported by:	mkoniecz	Owned by:	team
Priority:	normal	Milestone:	17.05
Component:	Core	Version:
Keywords:	template_report	Cc:

Description

What steps will reproduce the problem?

obtain maformed .osm file (my case is documented at https://github.com/MarcusWolschon/osmeditor4android/issues/556 )
load file in JOSM

What is the expected result?

JOSM complains about latitudes larger than 90

What happens instead?

JOSM has phantom node at 0, 0 - it is not displayed but marking rectangle over 0, 0 will mark it
To avoid adding malformed data I was not trying to upload malformed data, but it is possible that JOSM would push such invalid data to the database.

Please provide any additional information below. Attach a screenshot if possible.

https://gist.github.com/matkoniecz/74489c730817e0ca131f07ef64d57b80 has original example of malformed .osm file

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-05-07 02:37:03 +0200 (Sun, 07 May 2017)
Build-Date:2017-05-07 01:32:34
Revision:12081
Relative:URL: ^/trunk

Identification: JOSM/1.5 (12081 en) Linux Ubuntu 14.04.5 LTS
Memory Usage: 436 MB / 889 MB (83 MB allocated, but free)
Java version: 1.8.0_131-b11, Oracle Corporation, Java HotSpot(TM) Server VM
Screen: :0.0 1366x768, :0.1 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (33185)
+ RoadSigns (33204)
+ buildings_tools (33004)
+ measurement (33088)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/LessObtrusiveNodes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lit&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LitObjects&zip=1

Validator rules:
+ ${HOME}/Documents/OSM/josm.validator.mapcss

Last errors/warnings:
- E: org.openstreetmap.josm.io.IllegalDataException: Line 3 column 6: The processing instruction target matching "[xX][mM][lL]" is not allowed.. Cause: javax.xml.stream.XMLStreamException: ParseError at [row,col]:[3,6]
- E: Error - <html>Could not read file 'arg2.osm'.<br>Error is:<br>Line 3 column 6: The processing instruction target matching "[xX][mM][lL]" is not allowed.</html>
- E: org.openstreetmap.josm.io.IllegalDataException: Way with external ID '-3' includes missing node with external ID '-7'.
- E: Error - <html>Could not read file 'arg2.osm'.<br>Error is:<br>Way with external ID '-3' includes missing node with external ID '-7'.</html>
- E: Failed to locate image 'https://dl.dropboxusercontent.com/u/4031522/foto/gst_icon.png'
- E: Failed to locate image 'https://dl.dropboxusercontent.com/u/4031522/foto/gst_icon.png'
- E: Failed to locate image 'https://dl.dropboxusercontent.com/u/4031522/foto/gst_icon.png'
- E: Failed to locate image 'https://dl.dropboxusercontent.com/u/4031522/foto/gst_icon.png'
- E: Failed to locate image 'https://dl.dropboxusercontent.com/u/4031522/foto/gst_icon.png'
- E: Failed to locate image 'https://dl.dropboxusercontent.com/u/4031522/foto/gst_icon.png'