Add possibility to export validator warnings and errors

[Polyglot]

It would be nice if it were possible to export validator warnings to a JSON file. I would like to be able to use them on a web site for a specific dataset (In my case all public transport data for Belgium).

[Klumbumbus]

planned for gsoc project ​https://wiki.openstreetmap.org/wiki/Google_Summer_of_Code/2017/PT_Assistant_Plugin

[Don-vip]

See #15182

@giackserva: did you work on the subject, as originally planned on the wiki?

[Polyglot]

We had quite a few other features Giacomo worked on, that were more directly useful for the mappers.

[Don-vip]

ok no problem :) that's rather a core feature anyway.

[Don-vip]

Osmose has already a ​file format we can reuse/extend. Maybe this could lead to future interoperability :)

[Don-vip]

In 12667/josm:

see #14704 - allow to export validator errors ("Save as" in validator layer contextual menu). Same format than Osmose

[Don-vip]

In 12668/josm:

see #14704 - PMD

[Klumbumbus]

Produces e.g.

    <error class="2">
      <location lat="50.6996597" lon="12.8487661">
  <node id='3302732733' timestamp='2015-01-21T17:19:44Z' uid='550300' user='Klumbumbus' visible='true' version='1' changeset='28310606' lat='50.6996597' lon='12.8487661'>
    <tag k='addr:city' v='Thalheim/Erzgebirge' />
    <tag k='addr:country' v='DE' />
    <tag k='addr:housenumber' v='1a' />
    <tag k='addr:postcode' v='09380' />
    <tag k='addr:street' v='Friedrichstraße' />
    <tag k='club' v='social' />
    <tag k='name' v='Teelicht' />
    <tag k='social_facility' v='outreach' />
    <tag k='website' v='http://www.teelicht-thalheim.de/' />
  </node>
      <text lang="de" value="Schlüssel "club" nicht in Vorlagen.">
    </error>

It seems the " in the text element produces an invalid xml file. The indentation looks weired too.

[Don-vip]

In 12692/josm:

fix #14704 - properly encode strings

[Klumbumbus]

one remaining problem :) the text element is not properly closed

    <error class='2'>
      <location lat='50.6996597' lon='12.8487661'>
  <node id='3302732733' timestamp='2015-01-21T17:19:44Z' uid='550300' user='Klumbumbus' visible='true' version='1' changeset='28310606' lat='50.6996597' lon='12.8487661'>
    <tag k='addr:city' v='Thalheim/Erzgebirge' />
    <tag k='addr:country' v='DE' />
    <tag k='addr:housenumber' v='1a' />
    <tag k='addr:postcode' v='09380' />
    <tag k='addr:street' v='Friedrichstraße' />
    <tag k='club' v='social' />
    <tag k='name' v='Teelicht' />
    <tag k='social_facility' v='outreach' />
    <tag k='website' v='http://www.teelicht-thalheim.de/' />
  </node>
      <text lang='de' value='Schlüssel &quot;club&quot; nicht in Vorlagen.'>
    </error>

[Don-vip]

In 12698/josm:

see #14704 - fix xml tag

[Don-vip]

thanks!

[Klumbumbus]

I just noticed, there is the same problem for location too.

[Don-vip]

In 12699/josm:

see #14704 - fix xml tag