Modify

Opened 7 years ago

Closed 7 years ago

#14568 closed defect (fixed)

UI freezes on map change when Conflation is active

Reported by: bagage Owned by: team
Priority: normal Milestone:
Component: Plugin conflation Version: latest
Keywords: Cc: Tyndare

Description (last modified by bagage)

What steps will reproduce the problem?

  1. Configure Conflation with datasets
  2. Start it
  3. Change selection on the map. For instance select all trees, all buildings or…

What is the expected result?

The selection changes instantly.

What happens instead?

UI freezes because Conflation is listening to such changes and is doing some internal things to keep in sync with the map view. I believe too much things are done too quickly; we might avoid some of them by checking first if ListSelectionEvent.getValueIsAdjusting() is true to avoid intermediate updates?

Additional information below.

Build-Date:2017-03-24 10:36:25
Revision:11772
Is-Local-Build:true

Identification: JOSM/1.5 (11772 SVN en) Linux Debian GNU/Linux 9.0 (stretch)
Memory Usage: 829 MB / 1760 MB (611 MB allocated, but free)
Java version: 1.8.0_121-8u121-b13-4-b13, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-8-jre:amd64-8u121-b13-4
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-13
Program arguments: [${HOME}/CL096-CLERIEUX/test-small.osm]
Dataset consistency test: No problems found

Plugins:
+ PicLayer (33148)
+ conflation (0.5.1)
+ jts (32699)
+ rex (26)
+ utilsplugin2 (33182)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

Attachments (0)

Change History (3)

comment:1 by bagage, 7 years ago

Description: modified (diff)

comment:2 by Klumbumbus, 7 years ago

Cc: Tyndare added

comment:3 by Tyndare, 7 years ago

Resolution: fixed
Status: newclosed

Thanks for the proposition to use ListSelectionEvent.getValueIsAdjusting()
I've tried it, I also tried to limit the number of calls to update the list selection.
I consider it closed, but you can reopen if you think its possible to optimize it further.

https://github.com/JOSM/conflation/commit/0407e4b1e5cd5f846eb0dd2738567e05c3ff5c68
https://github.com/JOSM/conflation/commit/d09ef342b17ec779e7e47e4c1c2a4f12aca6c2d5

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.