Modify

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#14495 closed defect (fixed)

StyleCacheTest failing

Reported by: bastiK Owned by: michael2402
Priority: normal Milestone: 17.03
Component: Unit tests Version:
Keywords: test Cc:

Description

StyleCacheTest.testStyleCacheInternPool test is failing in Jenkins.

There is a problem with this test that it uses the current global MapCSS style, which is modified by other tests. So it is kind of random what this method tests. Whatever style it uses at the moment, is causing a test error.

Attachments (0)

Change History (10)

comment:1 Changed 2 years ago by stoecker

Means JOSMFixture.init() must be fixed?

comment:2 Changed 2 years ago by Don-vip

Cc: michael2402 added
Component: Core mappaintUnit tests

comment:3 Changed 2 years ago by Don-vip

Cc: michael2402 removed
Owner: changed from team to michael2402

3 other tests must be fixed:

org.openstreetmap.josm.gui.dialogs.InspectPrimitiveDialogTest.testBuildMapPaintText
org.openstreetmap.josm.gui.mappaint.MapCSSRendererTest.testRender[area-text]
org.openstreetmap.josm.data.validation.tests.MultipolygonTestTest.testTicket10469

comment:4 Changed 2 years ago by michael2402

In 11776/josm:

Reduce startup time of StyleCacheTest, use test rules, do not leak memory. See #14495

comment:5 Changed 2 years ago by michael2402

In 11777/josm:

See #14495 - move style source reset to JOSM test rules.

comment:6 Changed 2 years ago by bastiK

In 11797/josm:

see #14495 - fix immutable class non-constant field (by removing it)

comment:7 Changed 2 years ago by bastiK

In 11805/josm:

see #14495 - add debugging output

comment:8 Changed 2 years ago by bastiK

Resolution: fixed
Status: newclosed

In 11818/josm:

fixed #14495 - stale ElemStyles.defaultLinesIdx

comment:9 Changed 2 years ago by bastiK

I will get rid of all the public fields in org.openstreetmap.josm.gui.mappaint.styleelement.*, this is really not such a brilliant idea for immutable classes.

comment:10 Changed 2 years ago by michael2402

Agreed, I have not found a plugin that uses these fields.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain michael2402.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.