Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#14364 closed defect (fixed)

Overpass wizard geocoding doesn't interpret Nominatim responses correctly

Reported by: Stereo Owned by: team
Priority: major Milestone: 17.02
Component: Core Version:
Keywords: template_report Cc:

Description (last modified by Stereo)

What steps will reproduce the problem?

  1. Open the JOSM overpass dialog
  2. In the wizard, search for addr:street="Rue Plaetis" in Luxembourg
  3. Download

What is the expected result?

The same data as http://overpass-turbo.eu/s/mIS gets loaded in JOSM

What happens instead?

Dialog: No data found in this area

Please provide any additional information below. Attach a screenshot if possible.

Changes r11002 and r11003 introduced geocodeArea for the overpass wizard, but the current implementation is broken for places that are mapped both as a node and an area.

Both JOSM and overpass-turbo will call Nominatim for Luxembourg but they will use different IDs for the actual overpass API call:

  • JOSM will call area(424298019)->.searchArea; which is the id of the top node
  • Overpass-turbo will call area(3602171347)->.searchArea; which is the sum of the id of the top relation and the overpass relation constant

The relevant piece of code in overpass-turbo uses nominatim.getBest to only returns objects that aren't nodes.

Proposed fix: OverpassDownloadReader.java should look for the best Nominatim result that isn't a node, not just the best result.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-02-02 01:22:52 +0100 (Thu, 02 Feb 2017)
Build-Date:2017-02-02 02:33:28
Revision:11526
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11526 en_GB) Mac OS X 10.12.3
Memory Usage: 990 MB / 3641 MB (633 MB allocated, but free)
Java version: 1.8.0_31-b13, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 69731906 1920x1200
Maximum Screen Size: 1920x1200
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (33005)
+ CommandLine (33026)
+ DirectDownload (33004)
+ DirectUpload (32885)
+ FixAddresses (33004)
+ HouseNumberTaggingTool (32699)
+ ImportImagePlugin (33028)
+ ImproveWay (12)
+ OSMRecPlugin (33013)
+ OpeningHoursEditor (33004)
+ PicLayer (33088)
+ RoadSigns (33088)
+ alignways (33136)
+ apache-commons (32994)
+ apache-http (32699)
+ areaselector (1478814827)
+ auto_tools (1479831713)
+ buildings_tools (33004)
+ conflation (0.3.0)
+ contourmerge (1030)
+ download_along (32946)
+ ejml (32680)
+ geotools (33042)
+ gson (32680)
+ imagery-xml-bounds (33004)
+ imagery_offset_db (33004)
+ importvec (33088)
+ jts (32699)
+ livegps (33138)
+ log4j (32699)
+ mapdust (33044)
+ merge-overlap (33004)
+ namemanager (33004)
+ opendata (33088)
+ pdfimport (33004)
+ pt_assistant (33108)
+ public_transport (33088)
+ public_transport_layer (33088)
+ reltoolbox (33088)
+ reverter (33088)
+ rex (26)
+ routing (33004)
+ scripting (30764)
+ splinex (33140)
+ surveyor (33011)
+ tageditor (33021)
+ terracer (33088)
+ todo (30000)
+ turnrestrictions (33088)
+ undelete (32699)
+ utilsplugin2 (33124)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/BicycleJunction&preset&zip=1
+ http://osmtools.de/josm/steps.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Historic_Stone&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&preset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Towers&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Golf_Course&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportOneClick&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Bus_lanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Heritage&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Historical_Objects&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/public_bookcase&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Stolpersteine&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/BuildingPreset&zip=1
+ http://zibi.openstreetmap.org.pl/kendzi/k/Simple3dPreset/s3db-preset.zip

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lit&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LessObtrusiveNodes&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Noname&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Power&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PowerMapping&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/BesideTheRoad_Speed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/TreeCrownDiameter&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SlovakiaBicycleRoutes&style&zip=1
- https://github.com/simon04/coloured-addresses.mapcss/raw/master/dist/coloured-addresses.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Suburb&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&style&zip=1
- http://maps.openstreetmap.ie/josm/townland.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/SlovakiaBicycleRoutes&style&zip=1
- https://github.com/GlassOceanos/indoor-JOSM-style/archive/master.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/SlovakiaBicycleRoutes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleRoofTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleBuildingTags&zip=1

Validator rules:
+ http://www.openrailwaymap.org/validator/openrailwaymap.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1
+ http://www.openrailwaymap.org/validator/de-openrailwaymap.validator.mapcss

Last errors/warnings:
- W: Warning: Failed to scan file 'site-svn.openstreetmap.org-_applications_editors_josm_plugins_opendata_modules.txt' for module information. Skipping.
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$SelectAction@75b875fa
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$AddAction@1dac0206
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$PassAction@67faf760
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$MarkAction@6acbc1e1
- W: Unable to get color from '' for color preference 'extrude.main.line'
- W: Unable to get color from '' for color preference 'make.parallel.helper.line'

Attachments (0)

Change History (10)

comment:1 Changed 3 years ago by Stereo

Description: modified (diff)

comment:2 Changed 3 years ago by Stereo

Description: modified (diff)
Summary: overpass wizard geocoding doesn't interpret nominatim responses correctlyOverpass wizard geocoding doesn't interpret Nominatim responses correctly

comment:3 Changed 3 years ago by Stereo

Description: modified (diff)

comment:4 Changed 3 years ago by Stereo

Description: modified (diff)

comment:5 Changed 3 years ago by Don-vip

Milestone: 17.02

comment:6 Changed 3 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 11560/josm:

fix #14364 - Overpass wizard geocoding doesn't interpret Nominatim responses correctly

comment:7 Changed 3 years ago by Stereo

Already!? Thank you!!

comment:8 Changed 3 years ago by Don-vip

Thanks for submitting the best bug report of 2017 so far, if definitively helped me to break a record: 7 minutes \o/

comment:9 Changed 3 years ago by Stereo

Ohh, don't encourage me :)

comment:10 Changed 3 years ago by Don-vip

I have launched a manual generation of the new latest release, available in a few minutes. Good night! :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.