Modify

Opened 7 years ago

Closed 7 years ago

Last modified 4 months ago

#14315 closed defect (fixed)

[Patch] AlignWays: way highlights are not cleaned up

Reported by: IdealChain Owned by: team
Priority: normal Milestone:
Component: Plugin alignways Version:
Keywords: Cc:

Description

The AlignWays plugin has been nearly unusable for a long time, so I decided to debug the issue. Temporary overlay layers for the highlighted ways are created, but never successfully removed, because the instance hashcode of the segment changes between adding and removing the temporary layer.

The attached patch should fix both open tickets, #11923 and #12132.
Also, the plugin does not require a JOSM restart after installation.

Attachments (1)

alignways-hashcode-fix.patch (3.0 KB ) - added by IdealChain 7 years ago.

Download all attachments as: .zip

Change History (6)

by IdealChain, 7 years ago

comment:1 by Don-vip, 7 years ago

Resolution: fixed
Status: newclosed

Fixed in [o33133:33134].

comment:2 by Don-vip, 7 years ago

Thank you! Most plugins are abandoned by their authors and it's not always easy to fix issues, your help is highly appreciated :)

comment:3 by taylor.smock, 4 months ago

@IdealChain: I'm currently working on converting the JOSM plugin repo to git (see #23286). Do you have a preferred name/email for that?

in reply to:  3 comment:4 by IdealChain, 4 months ago

Sounds good, I remember that SVN was already very unfamiliar to use again after years.
Please use: Daniel Achleitner <daniel.achleitner@…>

comment:5 by taylor.smock, 4 months ago

Thank you. Here is a link to your contributions in the current WIP repo: https://github.com/tsmock/josm-osmsvn-svn2git/commits?author=IdealChain .

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.