Wrongly displaying aerialway=chair_lift + oneway=no with direction arrows

[naoliv]

Draw a way with aerialway=chair_lift + oneway=no and see how JOSM renders it with direction arrows indicating that it's oneway.

​https://wiki.openstreetmap.org/wiki/Key:aerialway says that Any two-way chairlifts should be tagged oneway=no

JOSM:

Build-Date:2017-01-18 10:04:40
Revision:11481
Is-Local-Build:true

Identification: JOSM/1.5 (11481 SVN pt_BR) Linux Debian GNU/Linux testing (stretch)
Memory Usage: 587 MB / 10206 MB (176 MB allocated, but free)
Java version: 1.8.0_111-8u111-b14-3-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1600x900, :0.1 1280x1024
Maximum Screen Size: 1600x1024
Java package: openjdk-8-jre:amd64-8u111-b14-3
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-13
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

[naoliv]

BTW, while at it, if we validate a way with aerialway=chair_lift + oneway=no JOSM also issues a wrong missing tag - oneway without highway or railway

[Klumbumbus]

It's strange, that a chair_lift should imply oneway=yes. Usually you can drive (or ride?) on a chair lift also downwards.

[naoliv]

I guess they say about oneway=no in cases like this, where only one way (line) is used to represent both directions?

ie, we don't draw two lines to represent the sides that ascend and descend.

[Klumbumbus]

Replying to naoliv:

I guess they say about oneway=no in cases like this, where only one way (line) is used to represent both directions?

I don't understand this sentence.

[naoliv]

Instead using two ways to represent the above picture, like this:

We use only one way with oneway=no:

[Klumbumbus]

Yes we map aerialways with a single line. However at nearly all chairlifts you can ride downwards too. So oneway=no should be implied. However the wiki says "This implies oneway=yes (drawn upward). Any two-way chairlifts should be tagged oneway=no." It make no sense to put oneway=no on 99% of all chair lifts.

Usually nobody used the chair lift downwards in winter, but you could ;)

[Klumbumbus]

In 11499/josm:

fix #14264 - displaying oneway direction arrows of aerialways according to wiki, don't display them if oneway=no is set

[Klumbumbus]

I added this to the discussion page: ​https://wiki.openstreetmap.org/wiki/Talk:Key:aerialway#implizit_oneway_of_chair_lift.3F

[Don-vip]

Unit test is failing: jenkins/job/JOSM/lastCompletedBuild/jdk=JDK8/testReport/org.openstreetmap.josm.corrector/ReverseWayNoTagCorrectorTest/testDirectionalTags/

[Klumbumbus]

In 11501/josm:

fix #14264 - fix unit test

[Don-vip]

In 11503/josm:

see #14264 - checkstyle

[Klumbumbus]

Replying to naoliv:

BTW, while at it, if we validate a way with aerialway=chair_lift + oneway=no JOSM also issues a wrong missing tag - oneway without highway or railway

forgot that part

[Klumbumbus]

In 11513/josm:

fix #14264 - don't warn about aerialway oneway combination

[Klumbumbus]

Ticket #14314 has been marked as a duplicate of this ticket.