#1425 closed enhancement (fixed)
JOSM exit;unsaved changes dialog
Reported by: | Owned by: | xeen | |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | Core | Version: | latest |
Keywords: | Cc: | none |
Description
On exiting without saving JOSM asks "There are unsaved changes. Discard the changes and continue?", giving Yes and No as options. This is highly dangerous, as several other applications use similar dialogs, but some of them with negated options ("Save before exiting?").
A better way to handle it is to name the buttons according to their result, like Gimp does:
Save the changes to image 'Untitled' before closing?
If you don't save the image, changes from the last XX seconds will be lost.
![Don't save] ![Cancel] ![Save]
While giving the last modification time is useful to determine if the last change was accidental or intentional, it's not absolutely necessary.
The following text might suit JOSM:
You have made changes since you last saved or uploaded. If you exit without saving, these changes will be lost forever.
![Save locally] ![Discard changes] ![Don't exit]
I haven't worked with Swing before (only SWT), so no patch, sorry.
Attachments (1)
Change History (5)
comment:1 by , 16 years ago
Keywords: | JOSM exit unsaved changes dialog added |
---|
comment:27 by , 16 years ago
Owner: | changed from | to
---|
This patch is on top of #1977 and adds the possibility to save changes before exiting. On a second thought it should be better to make "save" the default action though as proposed above.
by , 16 years ago
Attachment: | MakeExitDialogLessHazardous (default to save).patch added |
---|
Same as above but with Save and Exit actions switched
comment:29 by , 16 years ago
Component: | Internal mappaint style → Core |
---|---|
Keywords: | 01836359 removed |
Summary: | generic prevacid → JOSM exit;unsaved changes dialog |
consider a recent, duplicate ticket #1770, that proposes three buttons:
<Save then quit> <Quit without saving> <Cancel>