Old style SideButton usage (rasterfilter)

[skyper]

See #12994 for a resolution of this error.

From #14234 anonymous:

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-01-02 00:53:29 +0100 (Mon, 02 Jan 2017)
Build-Date:2017-01-02 02:33:21
Revision:11427
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11427 de) Mac OS X 10.12.2
Memory Usage: 817 MB / 910 MB (197 MB allocated, but free)
Java version: 1.8.0_101-b13, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 69732992 1280x800
Maximum Screen Size: 1280x800
VM arguments: [-Djava.library.path=/Applications/JOSM.app/Contents/MacOS, -DLibraryDirectory=${HOME}/Library, -DDocumentsDirectory=${HOME}/Documents, -DApplicationSupportDirectory=${HOME}/Library/Application Support, -DCachesDirectory=${HOME}/Library/Caches, -DSandboxEnabled=false, -Dapple.laf.useScreenMenuBar=true, -Dcom.apple.macos.use-file-dialog-packages=true, -Dcom.apple.macos.useScreenMenuBar=true, -Dcom.apple.mrj.application.apple.menu.about.name=JOSM, -Dcom.apple.smallTabs=true]
Dataset consistency test: No problems found

Plugins:
+ FixAddresses (33004)
+ HouseNumberTaggingTool (32699)
+ ImportImagePlugin (33028)
+ Mapillary (v1.3.2)
+ OpeningHoursEditor (33004)
+ PicLayer (33088)
+ RoadSigns (33088)
+ SimplifyArea (33004)
+ apache-commons (32994)
+ apache-http (32699)
+ buildings_tools (33004)
+ editgpx (33004)
+ ejml (32680)
+ geotools (33042)
+ gpxfilter (33004)
+ imagery_offset_db (33004)
+ imageryadjust (33004)
+ importvec (33088)
+ jts (32699)
+ log4j (32699)
+ measurement (33088)
+ photoadjust (33088)
+ rasterfilters (33088)
+ reltoolbox (33088)
+ reverter (33088)
+ splinex (33007)
+ tageditor (33021)
+ terracer (33088)
+ todo (30000)
+ turnlanes (33088)
+ undelete (32699)
+ utilsplugin2 (33088)
+ wikipedia (33098)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/SlovakiaBicycleRoutes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&zip=1

Last errors/warnings:
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$PassAction@39df0aec
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$MarkAction@33164b56
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.rasterfilters.actions.ShowLayerFiltersDialog@18e9aa1f

[Don-vip]

Fixed in [o33269].

[stoecker]

See [o33716] - use proper attach function.