Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#14054 closed defect (invalid)

New geometry in "Replace Geometry" does not keep history of replaced geometry

Reported by: skorasaurus Owned by: team
Priority: normal Milestone:
Component: Plugin utilsplugin2 Version: latest
Keywords: template_report replace geometry Cc:

Description

I've used the replace geometry shortcut on JOSM for several years. I typically use it when existing POIs are only a node; I draw a closed way (building) and then use replace geometry on both features. The way now includes the history of the POI.

While editing yesterday, I noticed that the history of the replaced geometry was not being included on the new way.

What steps will reproduce the problem?

  1. Select an existing node that has been uploaded to OSM.
  2. Draw a new closed way
  3. Select both features
  4. Press Cntrl+Shift+G

What is the expected result?

The new way should include history of the geometry that the new way had replaced.

What happens instead?

The new way has tags of the existing node but it does not have its history.

Please provide any additional information below. Attach a screenshot if possible.

I've included a sample file. Draw a building, and select the building and the existing node in the file and select replace geometry in More Tools Dialog.

You can verify that no history is on the by selecting the history (cntrl+H) or more information (cntrl+i) of the new way.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-11-27 02:52:18 +0100 (Sun, 27 Nov 2016)
Build-Date:2016-11-27 02:34:28
Revision:11323
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11323 en) Linux Ubuntu 14.04.5 LTS
Memory Usage: 1157 MB / 2617 MB (749 MB allocated, but free)
Java version: 1.8.0_111-8u111-b14-3~14.04-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-8-jre:amd64-8u111-b14-3~14.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.30.4-4
Dataset consistency test: No problems found

Plugins:
+ FixAddresses (33004)
+ ImproveWay (9)
+ Mapillary (v1.3.2)
+ OpenStreetView (28)
+ OpeningHoursEditor (33004)
+ apache-commons (32994)
+ apache-http (32699)
+ auto_tools (1479831713)
+ buildings_tools (33004)
+ ejml (32680)
+ geojson (52)
+ geotools (33042)
+ imagery_offset_db (33004)
+ jts (32699)
+ measurement (33088)
+ osm-obj-info (1468276210)
+ reltoolbox (33088)
+ reverter (33088)
+ terracer (33088)
+ todo (30000)
+ undelete (32699)
+ utilsplugin2 (33088)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/TigerReviewedNo&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AdvertisingStyle&zip=1
- https://github.com/hotosm/HDM-JOSM-style/archive/master.zip

Last errors/warnings:
- W: Invalid jar file ''<josm.pref>/plugins/buildings_tools.jar.new'' (exists: false, canRead: false)
- W: Invalid jar file ''<josm.pref>/plugins/measurement.jar.new'' (exists: false, canRead: false)
- W: Invalid jar file ''<josm.pref>/plugins/terracer.jar.new'' (exists: false, canRead: false)
- W: Invalid jar file ''<josm.pref>/plugins/OpeningHoursEditor.jar.new'' (exists: false, canRead: false)
- W: Invalid jar file ''<josm.pref>/plugins/apache-commons.jar.new'' (exists: false, canRead: false)
- W: Invalid jar file ''<josm.pref>/plugins/utilsplugin2.jar.new'' (exists: false, canRead: false)
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$SelectAction@1983ba86
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$AddAction@68be4f0
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$PassAction@1bf16266
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$MarkAction@2b083f66

Attachments (1)

replacegeometrybug.osm (511 bytes ) - added by skorasaurus 7 years ago.
A sample file to use.

Download all attachments as: .zip

Change History (5)

by skorasaurus, 7 years ago

Attachment: replacegeometrybug.osm added

A sample file to use.

comment:1 by skorasaurus, 7 years ago

Keywords: replace geometry added

comment:2 by Klumbumbus, 7 years ago

Resolution: invalid
Status: newclosed

You can't "transfer" the history of a node to a way (or between any other combination of two diferent object types).

Instead by using the replace geometry action the old node becomes one node of the new way. So the history for this node is kept.

comment:3 by skorasaurus, 7 years ago

My apologies for misunderstanding; thank you for the clarification and have a good day.

comment:4 by Klumbumbus, 7 years ago

No problem. Have a good day too :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.