Modify

Opened 17 years ago

Closed 15 years ago

#1405 closed defect (worksforme)

Validator info not always updated

Reported by: florianheerfheb@… Owned by: Team
Priority: major Milestone:
Component: Core validator Version: latest
Keywords: IndexOutOfBoundsException Cc: delta_foxtrot@…

Description

Josm version from svn, apparently 766.

Create a way with 3 nodes so that it overlaps itself (eg. draw a 4), tag it with for example highway=residential and try to upload => warning about crossing ways.
Now move the nodes so there is no overlapping => no warning at upload
Upload the changes.
Now again move the nodes so that the way crosses itself and try to upload => no warning.

Slighty different, but probably the same reason:
download a way without overlapping itself, move a node so that it will cross itself, and try to upload => no warning.

But then again: 3 nodes so the way overlaps itself, try upload => warning, move node to resolve that => no warning, don't upload but move the way again so it overlaps itself => warning at upload-attempt.

Attachments (0)

Change History (9)

comment:1 by Hasienda, 16 years ago

Keywords: IndexOutOfBoundsException added
Summary: conflict validation on upload not always updatedconflict info not always updated, IndexOutOfBoundsException at another occasion

not always updating confict information

see #548 for a predecessor of this ticket here

IndexOutOfBoundsException

see #1568 and #1785 (latest JOSM revision to date) for error messages regarding the subject mentioned here.

comment:2 by xeen, 16 years ago

Owner: changed from framm to xeen

I couldn't reproduce the problem using the given STR. I found a new one though:

  • Draw non-closed way
  • Tag it as an area (e.g. parking)
  • Uploading gives "area not closed" warning
  • Re-Tag it as highway or something that's really a way
  • Uploading still yields "area not closed" warning

If I remember correctly the Validator assumes a specific solution for certain errors in order to not have to check all tests again. I assume this was done for performance reasons, I'll see if the validator can do a full re-check on upload.

comment:3 by xeen, 16 years ago

Summary: conflict info not always updated, IndexOutOfBoundsException at another occasionValidator info not always updated, IndexOutOfBoundsException at another occasion

Oh, I just noticed. This is about the validator while the other two are about resolving conflicts. I'll reopen #1568.

comment:4 by anonymous, 16 years ago

Summary: Validator info not always updated, IndexOutOfBoundsException at another occasionValidator info not always updated

comment:5 by xeen, 16 years ago

Owner: changed from xeen to Team

not going to work on this anytime soon

comment:6 by delta_foxtrot2, 16 years ago

I can't reproduce the original bug.

I create a way in the shape of a number 4, highway=residential, try to upload and it warns about crossed ways, I move it and it no longer warns about crossed ways, I then move one node so they cross and I again get a warning about Crossed Ways.

comment:7 by delta_foxtrot2, 16 years ago

Cc: delta_foxtrot@… added

comment:8 by plaicy, 16 years ago

Component: CoreCore validator

comment:9 by stoecker, 15 years ago

Resolution: worksforme
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.