Modify

Opened 20 months ago

Closed 4 weeks ago

Last modified 4 weeks ago

#13937 closed defect (fixed)

Imagery offset bookmarks aren't locale independent

Reported by: naoliv Owned by: team
Priority: normal Milestone: 18.05
Component: Core imagery Version:
Keywords: offset Cc:

Description

Add some imagery offset bookmarks in any language, then start JOSM with LC_ALL=C exported.
See how there are no offset bookmarks available.
Using Bing, for example, it will happens if your language's translation for Bing aerial imagery differs from the English phrase.

Example:

https://i.imgur.com/Y6Iwjfp.png

First two entries where included with pt_BR. When starting JOSM with LC_ALL=C I just can't see them in the Imagery → Imagery offset menu.

JOSM should store the entries using some key that will make it available in any language, and not use the current locale translation.

JOSM:

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-11-06 20:18:38 +0100 (Sun, 06 Nov 2016)
Build-Date:2016-11-06 21:45:03
Revision:11223
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11223 pt_BR) Linux Debian GNU/Linux testing (stretch)
Memory Usage: 483 MB / 10206 MB (72 MB allocated, but free)
Java version: 1.8.0_111-8u111-b14-2-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1600x900, :0.1 1280x1024
Maximum Screen Size: 1600x1024
Java package: openjdk-8-jre:amd64-8u111-b14-2
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-9
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Attachments (0)

Change History (10)

comment:1 in reply to:  description Changed 20 months ago by Klumbumbus

Replying to naoliv:

JOSM should store the entries using some key that will make it available in any language, and not use the current locale translation.

The <id></id> tag would be available. Maps

Last edited 20 months ago by Klumbumbus (previous) (diff)

comment:2 Changed 8 months ago by Don-vip

Keywords: offset added

comment:3 Changed 4 weeks ago by Don-vip

Milestone: 18.05

comment:4 Changed 4 weeks ago by stoecker

Don't forget that ID is not always available (but nearly always).

comment:5 in reply to:  4 ; Changed 4 weeks ago by Don-vip

Replying to stoecker:

Don't forget that ID is not always available (but nearly always).

I've seen that (good javadoc :))

comment:6 in reply to:  5 Changed 4 weeks ago by stoecker

Replying to Don-vip:

Replying to stoecker:

Don't forget that ID is not always available (but nearly always).

I've seen that (good javadoc :))

Never trust a documentation. :-)

OTOH: Never trust somebody who tells you something you can check yourself ;-)

comment:7 Changed 4 weeks ago by Don-vip

Resolution: fixed
Status: newclosed

In 13797/josm:

fix #13937 - save imagery offset bookmarks by locale-insensitive id (when available)

comment:8 Changed 4 weeks ago by Don-vip

In 13798/josm:

see #13937 - code cleanup

comment:9 Changed 4 weeks ago by Don-vip

@naoliv: it won't work in all cases for old bookmarks, you will have to fix some of them manually. But there should not be any problems with new bookmarks.

comment:10 Changed 4 weeks ago by naoliv

Sure. Thank you!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.