Modify

Opened 8 years ago

Closed 7 years ago

#13932 closed enhancement (fixed)

Move some specific tests to country/regional rules

Reported by: naoliv Owned by: Don-vip
Priority: normal Milestone: 17.01
Component: Core validator Version:
Keywords: Cc:

Description

Attachments (0)

Change History (23)

comment:1 by Klumbumbus, 8 years ago

Yes. The "street name contains ss" info can then be raised to warning or even error level. Currently it produces lots of false positives in switzerland.

comment:2 by Klumbumbus, 8 years ago

Milestone: 16.11

comment:3 by Don-vip, 8 years ago

The checks are language-specific, so we can indeed improve the boundaries file to add official languages, based on information from ISO3166 + ISO639, so we could have something like:

*[language("en")] ... {
 ...
}

and the check would be applied only in countries or subdivisions where English is an official language.

comment:4 by Don-vip, 8 years ago

Owner: changed from team to Don-vip
Status: newassigned

in reply to:  3 ; comment:5 by Klumbumbus, 8 years ago

Replying to Don-vip:

the check would be applied only in countries or subdivisions where English is an official language.

That sounds interresting. However regarding the *[name =~ /(?i).*Strasse.*/] this one is country specific. Germany, Switzerland, Austria and Liechtenstein use the german language but only in Switzerland and Liechtenstein they write the word street with ss instead of ß (strasse instead of straße).

comment:6 by Klumbumbus, 8 years ago

The rules at Rules should also be adapted.

in reply to:  5 comment:7 by Klumbumbus, 7 years ago

Replying to Klumbumbus:

regarding the *[name =~ /(?i).*Strasse.*/] this one is country specific.

Here is my modification of the code:

*[name =~ /(?i).*Strasse.*/][inside("DE,AT")] {
  throwError: tr("street name contains ss");
}
*[name =~ /(?i).*Straße.*/][inside("LI,CH")] {
  throwError: tr("street name contains ß");
}

comment:8 by Don-vip, 7 years ago

Milestone: 16.1116.12

Milestone renamed

comment:9 by Don-vip, 7 years ago

Milestone: 16.1217.01

i18n impact => next milestone

comment:10 by Klumbumbus, 7 years ago

The test can be enhanced to addr:street

*[addr:street =~ /(?i).*Strasse.*/][inside("DE,AT")],
*[name =~ /(?i).*Strasse.*/][inside("DE,AT")] {
  throwError: tr("street name contains ss");
}
*[addr:street =~ /(?i).*Straße.*/][inside("LI,CH")],
*[name =~ /(?i).*Straße.*/][inside("LI,CH")] {
  throwError: tr("street name contains ß");
}
Last edited 7 years ago by Klumbumbus (previous) (diff)

comment:11 by Klumbumbus, 7 years ago

In 11439/josm:

  • see #13932 - make Straße/Strasse validator test country specific and raise to error level
  • feed ignore list

comment:12 by Don-vip, 7 years ago

Milestone: 17.0117.02

comment:13 by Don-vip, 7 years ago

Milestone: 17.0217.03

comment:14 by Don-vip, 7 years ago

Milestone: 17.0317.04

comment:15 by Don-vip, 7 years ago

Milestone: 17.0417.05

comment:16 by Don-vip, 7 years ago

Milestone: 17.0517.06

comment:17 by Don-vip, 7 years ago

Milestone: 17.0617.07

comment:18 by Don-vip, 7 years ago

Milestone: 17.0717.08

comment:19 by Don-vip, 7 years ago

Milestone: 17.0817.09

comment:20 by Don-vip, 7 years ago

Milestone: 17.0917.10

comment:21 by Don-vip, 7 years ago

Milestone: 17.10

comment:22 by Klumbumbus, 7 years ago

This ticket is fixed in my eyes. The Straße/Strasse test was adapted and the other test, this one:

way[highway][name =~ /(?i).* (Ave|Blvd|Br|Brg|Cct|Cir|Cl|Cr|Crct|Cres|Crt|Ct|Dr|Drv|Esp|Espl|Hwy|Ln|Mw|Mwy|Pky|Pkwy|Pl|Rd|Qy|Qys|Sq|St|Str|Ter|Tce|Tr|Wy)[.]?$/] {
  throwWarning: tr("abbreviated street name");
  assertMatch: "way highway=unclassified name=\"Foo Ave\"";
  assertMatch: "way highway=unclassified name=\"Foo Ave.\"";
  assertMatch: "way highway=unclassified name=\"Bou Blvd.\"";
  assertMatch: "way highway=unclassified name=\"Bou blvd.\"";
}

is hard to split into different countries/languages. We should keep it as is. We didn't yet receive any tickets about problems with this test.

comment:23 by Klumbumbus, 7 years ago

Milestone: 17.01
Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.