Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#13875 closed defect (fixed)

Possible wrong warning in route=bicycle

Reported by: naoliv Owned by: team
Priority: normal Milestone: 16.10
Component: Core validator Version:
Keywords: Cc:

Description

Validate the attached example and see a warning about lcn without highway
From what I understand, there is no need (nor it will be right) to have a highway in the relation (since we already have the highways defined in the ways; also, we could have different highway types defining this route)

JOSM:

Build-Date:2016-10-29 14:02:24
Revision:11186
Is-Local-Build:true

Identification: JOSM/1.5 (11186 SVN pt_BR) Linux Debian GNU/Linux unstable (sid)
Memory Usage: 798 MB / 4029 MB (147 MB allocated, but free)
Java version: 1.8.0_111-8u111-b14-2-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-8-jre:amd64-8u111-b14-2
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-9
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Attachments (1)

example.osm (1.0 KB) - added by naoliv 3 years ago.

Download all attachments as: .zip

Change History (10)

Changed 3 years ago by naoliv

Attachment: example.osm added

comment:1 Changed 3 years ago by Klumbumbus

According to my feelings and https://wiki.openstreetmap.org/wiki/Cycle_routes#Tagging_cycle_route_networks routes are tagged nowadays with network=icn/ncn/rcn/lcn at the relation instead of with icn=yes, ncn=yes, rcn=yes, lcn=yes at all the member highways, right?

comment:2 Changed 3 years ago by Klumbumbus

Milestone: 16.11

comment:3 Changed 3 years ago by naoliv

Will you convert icn|ncn|rcn|lcn into network=* in the relations?
Something like this?

If there is no network, convert
If there are both tags and they are the same, remove icn|ncn|rcn|lcn
If there are both and they diverge, issue a warning

Last edited 3 years ago by naoliv (previous) (diff)

comment:4 Changed 3 years ago by Klumbumbus

A way can belong to different route relations and different ways with different icn|ncn|rcn|lcn can belong to one or more route relations. So this requires manual transformation.

Anyway it is not really called deprecated in the wiki, so we should wait until the situation is more clear about the tagging. For now I'll remove the "lcn without highway" warning which is in fact false positive for your example (and to not promote this tag).

comment:5 in reply to:  4 Changed 3 years ago by naoliv

Replying to Klumbumbus:

A way can belong to different route relations and different ways with different icn|ncn|rcn|lcn can belong to one or more route relations. So this requires manual transformation.

Not on the ways, but on the relation itself.
This example that I sent here was based on some wrong routes that I saw (they had lcn=yes in the route relation and not on the ways)

So comment:3 will actually be:

"When there is a relation with icn|ncn|rcn|lcn, should it be automatically converted?"

comment:6 Changed 3 years ago by Klumbumbus

OK, I missunderstood. Well I think we should wait for a more clear statement in the wiki. Maybe you want to create a proposal "deprecate lcn/... in favor of network" ? :)

comment:7 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 11209/josm:

fix #13875 - remove "lcn without highway" warning

comment:8 Changed 3 years ago by Klumbumbus

Once the tagging situation and the wiki is more clear please create a new ticket. Then we can add a deprecated warning for lcn and its siblings.

comment:9 Changed 3 years ago by Klumbumbus

Milestone: 16.1116.10

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.