Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#13727 closed defect (fixed)

test waterway together with bridge gives false positive on waterway=weir

Reported by: anonymous Owned by: team
Priority: normal Milestone: 16.10
Component: Core validator Version:
Keywords: Cc:

Description

There are ways that represent a weir that also can be used to cross the water that are tagged like this:

bridge=yes
highway=path
waterway=weir

The validator gives a warning for this, but even worse, it also offers to repair it to bridge=aqueduct

Because waterway=weir isn't really a waterway, it's involved in more false positives. Sorry, I don't have any examples right now. But maybe waterway=weir should be excluded from all waterway=* tests.

Attachments (0)

Change History (3)

comment:1 Changed 3 years ago by Klumbumbus

Component: CoreCore validator
Milestone: 16.09

Validator warning should be improved. However waterway=weir + bridge=yes is not a valid combination. If it is a weir then water flows over it and then it is not a bridge but a ford.

And if there is a bridge over a weir, then these are two objects and you schould use one way with waterway=weir and one way with highway=* + bridge=yes + layer=1

Last edited 3 years ago by Klumbumbus (previous) (diff)

comment:2 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 11074/josm:

fix #13727 - improve "waterway=weir together with bridge=yes" warning

comment:3 Changed 3 years ago by simon04

Milestone: 16.0916.10

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.