Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#13653 closed defect (fixed)

defaultpresets.xml => item name="Emergency Access Point"

Reported by: i-re Owned by: team
Priority: normal Milestone: 16.10
Component: Internal preset Version: latest
Keywords: Emergency Access Point Cc: DD1GJ

Description (last modified by Don-vip)

What steps will reproduce the problem?

Create or edit Emergency Access Point including emergency call using default-preset.

What is the expected result?

  1. Using key "emergency_telephone_code" instead of "phone" for value emergency call (see: http://wiki.openstreetmap.org/wiki/Tag:highway%3Demergency_access_point )
  2. Omitting incorrect hint "(Use international code, like +12-345-67890)" because country codes are futile for emergency calls.

What happens instead?

  1. Key "phone" is used,
  2. Wrong values are inserted by users because of misleadingly hint.

Please provide any additional information below. Attach a screenshot if possible.

Please change:

<item name="Emergency Access Point" icon="presets/service/emergency_access_point.svg" type="node,closedway" preset_name_label="true">
        <link href="http://wiki.openstreetmap.org/wiki/Tag:highway=emergency_access_point"
                  de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:highway=emergency_access_point"
                  fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:highway=emergency_access_point"
                  pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:highway=emergency_access_point"
                  ru.href="http://wiki.openstreetmap.org/wiki/RU:Tag:highway=emergency_access_point" />
        <space />
        <key key="highway" value="emergency_access_point" />
        <text key="ref" text="Point Number" />
        <text key="name" text="Point Name" />
        <text key="operator" text="Operator" />
        <text key="phone" text="Phone Number" />
        <label text="(Use international code, like +12-345-67890)" />
        <space />
</item> <!-- Emergency Access Point -->

to:

<item name="Emergency Access Point" icon="presets/service/emergency_access_point.svg" type="node,closedway" preset_name_label="true">
        <link href="http://wiki.openstreetmap.org/wiki/Tag:highway=emergency_access_point"
                  de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:highway=emergency_access_point"
                  fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:highway=emergency_access_point"
                  pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:highway=emergency_access_point"
                  ru.href="http://wiki.openstreetmap.org/wiki/RU:Tag:highway=emergency_access_point" />
        <space />
        <key key="highway" value="emergency_access_point" />
        <text key="ref" text="Point Number" />
        <text key="name" text="Point Name" />
        <text key="operator" text="Operator" />
        <text key="emergency_telephone_code" text="Emergency number" />
        <label text="(Use number as shown on plate)" />
        <space />
</item> <!-- Emergency Access Point -->
URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-09-06 00:16:07 +0200 (Tue, 06 Sep 2016)
Build-Date:2016-09-05 22:21:00
Revision:10966
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10966 de) Linux openSUSE 13.2 (Harlequin) (x86_64)
Memory Usage: 610 MB / 7143 MB (441 MB allocated, but free)
Java version: 1.8.0_101-b13, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 2960x1050, :0.1 1680x1050
Maximum Screen Size: 2960x1050
Java package: java-1_8_0-openjdk:x86_64-1.8.0.101

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip

Attachments (0)

Change History (4)

comment:1 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:2 Changed 3 years ago by Klumbumbus

Keywords: preset removed
Milestone: 16.09

Sounds reasonable. Using phone would mean that you could call the emergency access point with this number ;)

some statistics (nodes only):

highway=emergency_access_point + phone: 1839 (147 of it outside of germany)
highway=emergency_access_point + emergency_telephone_code: 3572 (240 of it outside of germany)

comment:3 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 11025/josm:

fix #13653 - use emergency_telephone_code instead of phone for highway=emergency_access_point

comment:4 Changed 3 years ago by simon04

Milestone: 16.0916.10

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.