Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#13630 closed defect (fixed)

IllegalArgumentException: Unexpected '=' in validation

Reported by: naoliv Owned by: team
Priority: minor Milestone: 16.10
Component: Core validator Version:
Keywords: Cc:

Description

It seems I created an invalid validation rule and JOSM didn't like it:

fixRemove: "crossing=zebra";

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-09-12 21:15:56 +0200 (Mon, 12 Sep 2016)
Build-Date:2016-09-13 01:34:47
Revision:10996
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10996 pt_BR) Linux Debian GNU/Linux testing (stretch)
Memory Usage: 820 MB / 10206 MB (241 MB allocated, but free)
Java version: 1.8.0_102-8u102-b14.1-2-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1600x900, :0.1 1280x1024
Maximum Screen Size: 1600x1024
Java package: openjdk-8-jre:amd64-8u102-b14.1-2
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-9
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Plugins:
+ Create_grid_of_ways (32699)
+ ImportImagePlugin (32699)
+ OpeningHoursEditor (32699)
+ PicLayer (32796)
+ RoadSigns (32796)
+ SimplifyArea (32796)
+ apache-commons (32699)
+ buildings_tools (32944)
+ conflation (0.3.0)
+ contourmerge (1022)
+ download_along (32946)
+ editgpx (32699)
+ ejml (32680)
+ geojson (43)
+ geotools (32813)
+ importvec (32699)
+ indoorhelper (32680)
+ jts (32699)
+ log4j (32699)
+ measurement (32936)
+ merge-overlap (32699)
+ opendata (32898)
+ pbf (32865)
+ pdfimport (32796)
+ poly (32699)
+ reverter (32796)
+ scripting (30730)
+ todo (30000)
+ turnlanes (32796)
+ turnlanes-tagging (245)
+ turnrestrictions (32796)
+ undelete (32699)
+ utilsplugin2 (32815)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Noname&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Highway_Nodes&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- <josm.pref>/styles/indoor.mapcss
- /tmp/bla-style.mapcss
- https://dl.dropbox.com/u/8010189/Forum%20attachments/Hide_nodes.mapcss

Validator rules:
+ /arquivos/git/validador-josm/Rules_Brazilian-Specific.validator.mapcss
+ /arquivos/git/validador-josm/staging.validator.mapcss
- <josm.pref>/validator/indoorhelper.validator.mapcss

Last errors/warnings:
- W: java.io.IOException: Tags to paste are not valid.
- E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400
- E: Requisição inválida - <html>O servidor OSM 'overpass-api.de' reportou uma requisição inválida.<br></html>
- W: Unable to remove primitives from TestError [tester=org.openstreetmap.josm.data.validation.tests.CrossingWays$Ways@e2a654a4, code=601, message=Vias que se cruzam].: java.lang.UnsupportedOperationException
- W: java.net.SocketException: Socket closed
- E: java.net.SocketException: Socket closed
- W: org.openstreetmap.josm.io.OsmTransferCanceledException: Operation canceled. Causa: org.openstreetmap.josm.io.OsmTransferException: Não foi possível conectar com o servidor OSM. Por favor, verifique sua conexão de internet.. Causa: java.net.SocketException: Socket closed
- W: Unable to remove primitives from TestError [tester=org.openstreetmap.josm.data.validation.tests.UnconnectedWays$UnconnectedHighways@1829d189, code=1301, message=Nó final da via próximo de outra via].: java.lang.UnsupportedOperationException
- W: Unable to remove primitives from TestError [tester=org.openstreetmap.josm.data.validation.tests.UnconnectedWays$UnconnectedHighways@1829d189, code=1301, message=Nó final da via próximo de outra via].: java.lang.UnsupportedOperationException
- W: Unable to remove primitives from TestError [tester=org.openstreetmap.josm.data.validation.tests.UnconnectedWays$UnconnectedHighways@1829d189, code=1301, message=Nó final da via próximo de outra via].: java.lang.UnsupportedOperationException


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: File Watcher (12)
java.lang.IllegalArgumentException: Unexpected '='. Please only specify the key to remove!
	at org.openstreetmap.josm.tools.CheckParameterUtil.ensureThat(CheckParameterUtil.java:105)
	at org.openstreetmap.josm.data.validation.tests.MapCSSTagChecker$TagCheck.ofMapCSSRule(MapCSSTagChecker.java:320)
	at org.openstreetmap.josm.data.validation.tests.MapCSSTagChecker$TagCheck.readMapCSS(MapCSSTagChecker.java:381)
	at org.openstreetmap.josm.data.validation.tests.MapCSSTagChecker.addMapCSS(MapCSSTagChecker.java:723)
	at org.openstreetmap.josm.io.FileWatcher.processEvents(FileWatcher.java:148)
	at java.lang.Thread.run(Thread.java:745)

Attachments (0)

Change History (6)

comment:1 Changed 3 years ago by Klumbumbus

Resolution: worksforme
Status: newclosed

This is a coding error of your validation file. As the exception says "Please only specify the key to remove!" you can fix this by removing =zebra from your validation file and restart JOSM.

comment:2 Changed 3 years ago by naoliv

Yes, I know where the error is.
But shouldn't/couldn't it be handled exactly like other mapcss errors?
I never saw JOSM popping up an error dialog, no matter how wrong my rules were.

comment:3 Changed 3 years ago by Klumbumbus

Resolution: worksforme
Status: closedreopened

comment:4 Changed 3 years ago by Don-vip

Milestone: 16.09
Priority: normalminor

comment:5 Changed 3 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 11014/josm:

fix #13630 - proper validation of invalid mapcss rules

comment:6 Changed 3 years ago by simon04

Milestone: 16.0916.10

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.