Modify

Opened 9 years ago

Closed 6 years ago

#13492 closed enhancement (fixed)

Fix errors is very slow

Reported by: GerdP Owned by: team
Priority: normal Milestone: 19.03
Component: Core Version:
Keywords: Performance Fix-Error Cc: james2432

Description

See #13491, same steps and test data.
One problem here is that StyledMapRenderer.render() is executed for each "duplicate" node that is "fixed". On my machine that means that maybe one error is fixed per second.
Since all the duplicate nodes are marked with a yellow dot in the "Validation errors"
you will not see any change in the data layer. I don't know if it is intended to redraw, if yes, I think one redraw after each error class should be enough.
When I hide the layers the "fix" action for > 2000 errors is finished within 1 or 2 seconds.
This problem is also in r10916 and r10786 from http://josm.openstreetmap.de

Attachments (0)

Change History (4)

comment:1 by naoliv, 9 years ago

Seems to be #10676/#10101?

comment:2 by GerdP, 9 years ago

Yes, it is related to the general slowness when "large" number of nodes are processed, but what I wanted to point out is that
there is no need to render the data after each change, at least it doesn't help the user in any way. I have no idea yet how complicated it is to change that. In fact, when I select all errors and click on Fix, I expect that all errors which can be fixed are fixed in a single action, so that a single undo gets me back to the original status.

comment:3 by james2432, 9 years ago

Cc: james2432 added

comment:4 by GerdP, 6 years ago

Milestone: 19.03
Resolution: fixed
Status: newclosed

fixed with r14845

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.