Modify ↓
Opened 7 years ago
Closed 7 years ago
#13439 closed enhancement (fixed)
[Patch] Node.toString() and Way.toString() causing performance problems
| Reported by: | GerdP | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 16.08 |
| Component: | Core | Version: | |
| Keywords: | performance | Cc: |
Description
These methods are called heavily by
javax.swing.DefaultListCellRenderer.getListCellRendererComponent(JList, Object, int, boolean,boolean) which is called by
org.openstreetmap.josm.gui.OsmPrimitivRenderer.getListCellRendererComponent(JList, OsmPrimitive, int, boolean, boolean)
When you load a dataset with many ways and nodes and press Strg+A to select all objects
or search for something that appers very often. Since these methods are rather complex,
the dialog reacts very slow.
If I got that right, the result of the toString() is not even used in these cases.
I think it would be a good idea to not use DefaultListCellRenderer here.
Attachments (1)
Change History (6)
Changed 7 years ago by
| Attachment: | 13439.patch added |
|---|
comment:1 Changed 7 years ago by
| Summary: | Node.toString() and Way.toString() causing performance problems → [Patch} Node.toString() and Way.toString() causing performance problems |
|---|
comment:2 Changed 7 years ago by
| Summary: | [Patch} Node.toString() and Way.toString() causing performance problems → [Patch] Node.toString() and Way.toString() causing performance problems |
|---|
comment:3 Changed 7 years ago by
| Keywords: | performance added |
|---|
comment:4 Changed 7 years ago by
| Milestone: | → 16.08 |
|---|
Note: See
TracTickets for help on using
tickets.
The attached patch solves the problem. Since the value is not used we can pass a null value
so that toString() is not called.