in wireframe mode, some line segments are invisible

[eladner]

What steps will reproduce the problem?

1. Download some data.
2. Switch to wireframe mode.
3. Look around for missing segments. It's random. I can download an area and certain segments will be missing. Delete the layer, re-download the exact same area and different segments will be missing.

What is the expected result?

Ways should be rendered fully.

What happens instead?

Internal segments within a way do not show. Their presence can be seen by the "+" handle in the middle of the segment, but it's not drawn at all. Also note that it's not the copmlete way that's invisible, but only some internal segments between nodes.

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-08-23 00:45:29 +0200 (Tue, 23 Aug 2016)
Build-Date:2016-08-23 01:33:46
Revision:10877
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10877 en) Linux Ubuntu 15.10
Memory Usage: 524 MB / 3641 MB (288 MB allocated, but free)
Java version: 1.8.0_101-b13, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-DproxyHost=xxx, -DproxyPort=xxx]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (32773)
+ apache-commons (32699)
+ buildings_tools (32796)
+ download_along (32730)
+ ejml (32680)
+ ext_tools (32796)
+ geotools (32813)
+ jts (32699)
+ log4j (32699)
+ opendata (32811)
+ reltoolbox (32796)
+ splinex (32796)
+ turnlanes (32796)
+ turnlanes-tagging (1471546398)
+ utilsplugin2 (32815)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1

[eladner]

screen shot (annotated)

[Don-vip]

Michael, do you know what causes this?

[michael2402]

It happens if two adjacent points have exactly the same north or east coordinate.

It was a problem with the Java2D rectangle intersection for the in-view test: A rectangle is not intersecting an other rectangle if it has a width/height of 0.

I changed the code to use the outside flags the MapCSS code uses. They should be faster - although drawing is dominated by line painting. You will probably only notice it when displaying a short segment of a way with thousands of nodes.

[Don-vip]

In 10884/josm:

fix #13427 - in wireframe mode, some line segments are invisible (patch by michael2402)