Changes between Initial Version and Version 2 of Ticket #13396


Ignore:
Timestamp:
2016-08-20T19:42:33+02:00 (9 years ago)
Author:
Don-vip
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #13396 – Description

    initial v2  
    1 I've noticed that MatchingReferrerFinder.visit(Way w) is using a sequential search
    2 through all way nodes to find the index of the node. This index is only used when the
    3 corresponding style rule uses it, in the default file elemstyles.mapcss no rule uses
    4 it. The same seq. search is done for members of relations, and again, no default rule
    5 uses this. I've created a quick hack which avoids the search when the only information
    6 that is needed is whether the parent way (relation) matches.
     1I've noticed that `MatchingReferrerFinder.visit(Way w)` is using a sequential search through all way nodes to find the index of the node. This index is only used when the corresponding style rule uses it, in the default file elemstyles.mapcss no rule uses it. The same seq. search is done for members of relations, and again, no default rule uses this. I've created a quick hack which avoids the search when the only information that is needed is whether the parent way (relation) matches.
    72
    8 I guess a cleaner solution would be to add a boolean field indexNeeded in the selector
    9 which would be set when the rule contains the index clause (or the role clause).
     3I guess a cleaner solution would be to add a boolean field `indexNeeded` in the selector which would be set when the rule contains the index clause (or the role clause).
    104I leave that to the experts.
    11