Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#13352 closed enhancement (fixed)

[Patch] Adding a new bug report queue.

Reported by: michael2402 Owned by: team
Priority: normal Milestone: 16.08
Component: Core bugreport Version:
Keywords: gsoc-core Cc: Don-vip, bastiK, stoecker

Description

Add a new queue that handles bug report dialog display.

We do not need MapView to check for an active exception handling dialog. If the exception happens again, it will be added to the queue. A good guess is done to allow the user to suppress duplicate messages, so the user is still able to save if e.g. rendering fails.

Attachments (2)

patch-bugreport-queue.patch (21.9 KB) - added by michael2402 3 years ago.
patch-fix-13352.patch (22.3 KB) - added by michael2402 3 years ago.

Download all attachments as: .zip

Change History (8)

Changed 3 years ago by michael2402

Attachment: patch-bugreport-queue.patch added

comment:1 Changed 3 years ago by Don-vip

Owner: changed from team to michael2402
Status: newneedinfo

does not apply cleanly

Changed 3 years ago by michael2402

Attachment: patch-fix-13352.patch added

comment:2 Changed 3 years ago by michael2402

Owner: changed from michael2402 to team
Status: needinfonew

comment:3 Changed 3 years ago by Don-vip

            try {
                e.printStackTrace();
            } catch (RuntimeException e2) {
                // we cannot do anything more...
                // re-throwing this causes an infinite loop.
            }

Isn't it a bit overkill? Did you really find a case where printStackTrace throws an exception?

comment:4 Changed 3 years ago by michael2402

I wanted to overwrite it in ReportedException to only print the real, original stack trace. printStackTrace also calls getMessage() which may be implemented by an user to e.g. format the message.

But yes, it is very unlikely to happen ;-).

comment:5 Changed 3 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 10819/josm:

fix #13352 - new bug report queue (patch by michael2402) - gsoc-core

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.