Unable to run unit tests on Windows command line

[GerdP]

I tried the sample shown at the bottom of
https://josm.openstreetmap.de/wiki/DevelopersGuide/Compiling#CompilingusingEclipse

This is what I get:

E:\josm\core>set TESTCP=".;test/unit:test/functional;dist/josm-custom.jar;test/lib/fest/*;test/lib/junit/*;test/lib/*;test/lib/unitils-core/*" 

E:\josm\core>javac -cp ".;test/unit:test/functional;dist/josm-custom.jar;test/lib/fest/*;test/lib/junit/*;test/lib/*;test/lib/unitils-core/*" test/unit/org/openstreetmap/josm/data/projection/ProjectionRefTest.java 

E:\josm\core>java -cp ".;test/unit:test/functional;dist/josm-custom.jar;test/lib/fest/*;test/lib/junit/*;test/lib/*;test/lib/unitils-core/*" org.junit.runner.JUnitCore org.openstreetmap.josm.data.projection.ProjectionRefTest 
JUnit version 4.12
.E
Time: 0,002
There was 1 failure:
1) initializationError(org.junit.runner.JUnitCommandLineParseResult)
java.lang.IllegalArgumentException: Could not find class [org.openstreetmap.josm.data.projection.ProjectionRefTest]
	at org.junit.runner.JUnitCommandLineParseResult.parseParameters(JUnitCommandLineParseResult.java:102)
	at org.junit.runner.JUnitCommandLineParseResult.parseArgs(JUnitCommandLineParseResult.java:50)
	at org.junit.runner.JUnitCommandLineParseResult.parse(JUnitCommandLineParseResult.java:44)
	at org.junit.runner.JUnitCore.runMain(JUnitCore.java:72)
	at org.junit.runner.JUnitCore.main(JUnitCore.java:36)
Caused by: java.lang.ClassNotFoundException: org.openstreetmap.josm.data.projection.ProjectionRefTest
	at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:348)
	at org.junit.internal.Classes.getClass(Classes.java:16)
	at org.junit.runner.JUnitCommandLineParseResult.parseParameters(JUnitCommandLineParseResult.java:100)
	... 4 more

FAILURES!!!
Tests run: 1,  Failures: 1

[Don-vip]

Have you compiled JOSM first? Using ant clean dist

[GerdP]

Yes, I did (and tried it again now with the same result as above)

[Don-vip]

There was a typo (':' instead of ';'). The wiki is fixed.

[GerdP]

Yes, sorry, I also noticed this and forgot to report it.
It was not the solution when I reported the problem, but with r10853 this problem
is solved. Thanks!

Still, there seems to be another problem with unit tests on Windows. I see a crash
and many "FAILED" messages, still the final message is "BUILD SUCCESSFUL". See attached files
hs_err_pid6240.log and 10853-build-and-test.log.
This crash is not new, I think I always saw it when I tried to execute the unit tests. I think I first
tried when I opened ticket #13250.

[Don-vip]

Yes the bug is known (see #13001) and reported to Oracle already: ​javabug:8159956
It's resolved in Java 9b130 but not backported to Java 8 yet

[GerdP]

It seems that one of the last changes changed this so that the crash is gone now.
On the other hand, the unit tests are a bit confusing as they open new tabs in the browser or start to play
audio files. Is that intended?

[Don-vip]

Replying to Gerd Petermann <gpetermann_muenchen@…>:

On the other hand, the unit tests are a bit confusing as they open new tabs in the browser or start to play
audio files. Is that intended?

The goal was to maximize coverage on Jenkins, where it does not cause any problem. Maybe we could disable these tests on non-headless environments.

[GerdP]

Replying to Don-vip:

Replying to Gerd Petermann <gpetermann_muenchen@…>:

On the other hand, the unit tests are a bit confusing as they open new tabs in the browser or start to play
audio files. Is that intended?

The goal was to maximize coverage on Jenkins, where it does not cause any problem. Maybe we could disable these tests on non-headless environments.

I think this would be better. Besides the spooky feeling you have to react on dialog boxes, else the test is blocked.