Clean up program startup (parameters, logging)

[michael2402]

I cleaned up the MainApplication class more.

Things included:

• A new logging class with log level constants
• A new class to parse the command line arguments
• Some cleanup in the initialization tasks

I wrote a new class to log the warning/error messages. The class basically does what main did. But it also traces the source of the log call (as good as the VM allows us to). main is relaying all log calls. So currently you only get messages like (format can be changed):

Aug 11, 2016 3:15:04 PM org.openstreetmap.josm.Main info
INFORMATION: Erweiterung 'ImportImagePlugin' wird geladen (Version 32584)

We have two solutions here:

1. Ignore the calls from main, use the method that called Main.warn
2. Deprecate all Main logging methods. This will remove over 200 lines from that class.

I prefer option 2, but it will require a lot of changes to existing source code (but most calls will be search + replace). Stats:

Main.error  325
Main.warn   353
Main.info   109
Main.debug  175
Main.trace  147

There are currently 624 files depending on Main for various reasons. We may reduce that dependency by approx 100 files with this.

[Don-vip]

Patch does not apply cleanly

[michael2402]

Thanks for the hint. I added a new version ;-)

[Don-vip]

Still errors with JOSMFixture, and MainTest needs update :)

[michael2402]

Thanks for the hint ;-).

I added a new test for the Logging class, 99% coverage (with result checking)

[Don-vip]

Still not ok, is there a problem with your branch?

[michael2402]

It may have been that the git mirror lacks behind master. I'll have a look at it tomorrow.

[Don-vip]

It's a huge patch to merge manually, can you please help me to get a clean patch?

[michael2402]

Oh, sorry. I already cleaned it but forgot to attach the patch after travis was through with it.

The newest version is at:
​https://github.com/michaelzangl/josm/commit/6eaf0f2bcaf31eaec484228d4989b04645193892

It is 5 days old, so there may already be some comflicts. I'll update the patch to the current JOSM version and then attach it.

[Don-vip]

In 10899/josm:

fix #13318 - Clean up program startup (parameters, logging) - patch by michael2402 - gsoc-core

[Don-vip]

3 unit test failures:

org.openstreetmap.josm.tools.bugreport.BugReportTest.testGetCallingMethod
org.openstreetmap.josm.tools.bugreport.BugReportTest.testIntercept
org.openstreetmap.josm.tools.bugreport.BugReportTest.testReportText

[michael2402]

Fix getCallingMethod offset - there is one more call in between now.

​diff, ​patch,

Commits:

1. ​0dfb4e2: Fix getCallingMethod offset - there is one more call in between now.

Stats:

 src/org/openstreetmap/josm/tools/bugreport/BugReport.java | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

[Don-vip]

In 10902/josm:

fix #13318 - fix bug report (patch by michael2402) - gsoc-core

[michael2402]

In 10909/josm:

See #13318. MainApplication: Make log message for log level display the level.

[simon04]

r10899 causes this error-prone warning:

    [javac] /home/simon/src/josm.svngit/src/org/openstreetmap/josm/tools/Logging.java:69: warning: [UnsynchronizedOverridesSynchronized] Unsynchronized method publish overrides synchronized method in StreamHandler
    [javac]             public void publish(LogRecord record) {
    [javac]                         ^
    [javac]     (see http://errorprone.info/bugpattern/UnsynchronizedOverridesSynchronized)
    [javac]   Did you mean 'public synchronized void publish(LogRecord record) {'?

[michael2402]

No. This is a false positive. The parent method is not even synchronized, only the parent of the parent is.

The Idea behind it is, that you do not need to lock the object for the log level check.

[Don-vip]

reported upstream: ​https://github.com/google/error-prone/issues/455

[Don-vip]

I agree it's false positive, let Google fix this one.

[simon04]

In 11165/josm:

see #13318 - more concise logging output