Auto split changesets with over 10,000 changes

[planemad]

In preparation for possible API change ​https://github.com/openstreetmap/openstreetmap-website/pull/1259 that could impact ongoing imports.

JOSM should automatically create multiple changesets when uploading more than 10k changes. This avoids unnecessarily big changesets.

[maning]

JOSM already does this: https://josm.openstreetmap.de/wiki/Help/Action/Upload#ChangesetFull
Should this more obvious in the UI?

maning

[planemad]

Current behavior is to show this dialog https://josm.openstreetmap.de/wiki/Help/Action/Upload#ChangesetFull

Any reason why continue upload is not the default behaviour? What are the use cases to use any of the other options, seems like an unnecessary step for the user?

[naoliv]

There is already an option to configure the behavior at https://josm.openstreetmap.de/wiki/Help/Action/Upload#Runningaverylargeupload
I don't think that it's necessary to change anything in https://josm.openstreetmap.de/wiki/Help/Action/Upload#ChangesetFull

[taylor.smock]

I don't think this is an issue since we do have the ability to split into multiple changesets. In fact, I think we have a ticket somewhere about splitting into multiple changesets more intelligently, i.e.

while (changesetElements.size() < apiMax) {
    Relation next = changedRelations.pop();
    if (getDifferentElements(getRecursiveElements(next)).size() + changesetElements.size() < apiMax) {
        addRecursive(next);
    } else {
        closeCurrentChangeset();
        openNewChangeset();
    }
}