Opened 9 years ago
Closed 9 years ago
#13223 closed enhancement (fixed)
[Patch] Minor command class fixes
| Reported by: | michael2402 | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 16.07 |
| Component: | Unit tests | Version: | |
| Keywords: | gsoc-core | Cc: | Don-vip, bastiK, stoecker |
Description
I started to fix some minor command issues some time ago. I added test cases for them. Since this was very low priority I never took the time to finish it but it should be applied before doing too many Java8 changes.
Fixes include:
ChangeNodesCommandfails if nodes are empty (to prevent a plugin from creating empty ways)ChangePropertyCommanddid not count empty strings as not setChangePropertyKeyCommandonly sets modified if the object was changedChangePropertyKeyCommandcreates the right child commandsChangeRelationMemberRoleCommand:executeCommand()always returnstrueChangeRelationMemberRoleCommand: threw Exception if executeCommand() did not change anythingRotateCommand/ScaleCommand: Constructor has more flexible genericsRotateCommand: Performance improvementsSelectCommand: Copy the selection list*CommandTest: Increase test coverage to ~90% (real tests)
All patches in between should apply nicely. You can get them on github:
https://github.com/michaelzangl/josm/commits/test-command (starting with Commands: tests )
https://github.com/michaelzangl/josm/commits/test-command-2 (starting with Code cleanup.)
Attachments (1)
Change History (2)
by , 9 years ago
| Attachment: | patch-test-command-3.patch added |
|---|
comment:1 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |



In 10663/josm: