Opened 8 years ago

Last modified 8 years ago

#13217 closed enhancement

replace png icons by svg from osm svn source, sort icons and remove duplicates — at Version 9

Reported by: Klumbumbus Owned by: Klumbumbus
Priority: normal Milestone: 16.07
Component: Core Version:
Keywords: Cc:

Description (last modified by Klumbumbus)

follow up from https://josm.openstreetmap.de/ticket/13084#comment:34

icon paths adapted:

  • ✔ internal styles and preset
  • ✔ wiki based styles and presets

outstanding external icon paths:

Change History (9)

comment:1 by Klumbumbus, 8 years ago

Summary: replace png icons by svg from osm svn source and sort iconsreplace png icons by svg from osm svn source, sort icons and remove duplicates

comment:2 by Klumbumbus, 8 years ago

Milestone: 16.0816.07

Patch is ready, I will commit it today. (This should be in milestone 16.07 to not break external styles/presets for tested users for a long time.)

comment:3 by Klumbumbus, 8 years ago

In 10706/josm:

see #13217 - replace about 166 png icons by svg from https://trac.openstreetmap.org/browser/subversion/applications/share/map-icons/svg reworked most of them (white background or halo, resizing, pixel alignement), draw a few new svg icons from png derived; remove duplicate icons; reorder icons; adapt internal preset and mappaint styles

comment:4 by Klumbumbus, 8 years ago

Some stats:

In images folder there are now:

  • 564 png files
  • 569 svg files
  • 1133 total

For the images/presets folder the numbers are:

  • 162 png files
  • 508 svg files
  • 670 total

comment:5 by bastiK, 8 years ago

Great work!

In the mapcss style, we now rely on the fact that big images get scaled down to 16x16 px. As this value is hardcoded and somewhat arbitrary, I wonder if this could be specified explicitly? Would it help to have a new MapCSS feature for this?

E.g. icon-size: 16; could be used to scale an image proportionally, such that the larger of the two dimensions (width / height) is 16 px.
Or icon-max-size: 16; - the same, only that an image smaller that 16 px remains unscaled.

comment:6 by Klumbumbus, 8 years ago

In 10707/josm:

see #13217 - fix some icons; see #13204 - add reef mappaint style and icon (https://openclipart.org/detail/172292/corals, modified, PD, CC0)

comment:7 by Klumbumbus, 8 years ago

In 10709/josm:

see #13217, see #13204 - fix two icons

comment:8 by Klumbumbus, 8 years ago

Description: modified (diff)

comment:9 by Klumbumbus, 8 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.