replace png icons by svg from osm svn source, sort icons and remove duplicates

[Klumbumbus]

follow up from https://josm.openstreetmap.de/ticket/13084#comment:34

icon paths adapted:

• internal styles and preset
• wiki based styles and presets
• ​https://github.com/species/josm-preset-transformap/pull/3
• ​https://github.com/species/josm-preset-wheelchair/pull/2
• ​https://github.com/OpenNauticalChart/josm/pull/3
• ​https://github.com/hotosm/HDM-JOSM-style/pull/71
• ​https://github.com/OsmHackTW/josm-presets/pull/3

outstanding external icon paths:

• ​https://github.com/rurseekatze/OpenRailwayMap/pull/531
• ​http://wiki.openstreetmap.org/wiki/User_talk:Michi2#JOSM_preset
• ​http://wiki.openstreetmap.org/wiki/User_talk:IrlJidel#JOSM_preset
• ​https://github.com/yopaseopor/traffic_signs_preset_JOSM/issues/8

[Klumbumbus]

Patch is ready, I will commit it today. (This should be in milestone 16.07 to not break external styles/presets for tested users for a long time.)

[Klumbumbus]

In 10706/josm:

see #13217 - replace about 166 png icons by svg from ​https://trac.openstreetmap.org/browser/subversion/applications/share/map-icons/svg reworked most of them (white background or halo, resizing, pixel alignement), draw a few new svg icons from png derived; remove duplicate icons; reorder icons; adapt internal preset and mappaint styles

[Klumbumbus]

Some stats:

In images folder there are now:

• 564 png files
• 569 svg files
• 1133 total

For the images/presets folder the numbers are:

• 162 png files
• 508 svg files
• 670 total

[bastiK]

Great work!

In the mapcss style, we now rely on the fact that big images get scaled down to 16x16 px. As this value is hardcoded and somewhat arbitrary, I wonder if this could be specified explicitly? Would it help to have a new MapCSS feature for this?

E.g. icon-size: 16; could be used to scale an image proportionally, such that the larger of the two dimensions (width / height) is 16 px.
Or icon-max-size: 16; - the same, only that an image smaller that 16 px remains unscaled.

[Klumbumbus]

In 10707/josm:

see #13217 - fix some icons; see #13204 - add reef mappaint style and icon (​https://openclipart.org/detail/172292/corals, modified, PD, CC0)

[Klumbumbus]

In 10709/josm:

see #13217, see #13204 - fix two icons

[Klumbumbus]

404 new icon paths

[Klumbumbus]

Replying to bastiK:

E.g. icon-size: 16; could be used to scale an image proportionally, such that the larger of the two dimensions (width / height) is 16 px.

Would be nice, so you don't need to care about which one (width or height) is bigger, but I don't see this as high priority.

The more confusing (and error-prone) part is that svg icons between 16 and 64(?) px don't scale down, while bigger ones scale down again. Therefore I resized several icons in r10706.

[naoliv]

Sorry if it's already known:

ERROR: Failed to locate image 'presets/car.png'
WARNING:  Car: Could not get presets icon presets/car.png
ERROR: Failed to locate image 'presets/bed.png'
WARNING:  Amenity: Could not get presets icon presets/bed.png
ERROR: Failed to locate image 'presets/shop/mall.png'
WARNING:  Shops: Could not get presets icon presets/shop/mall.png
ERROR: Failed to locate image 'presets/landuse.png'
WARNING:  Landuse: Could not get presets icon presets/landuse.png
ERROR: Failed to locate image 'presets/military.png'
WARNING:  Military: Could not get presets icon presets/military.png
ERROR: Failed to locate image 'presets/firebrigade.png'
WARNING:  Emergency: Could not get presets icon presets/firebrigade.png
ERROR: Failed to locate image 'presets/sport/soccer.png'
WARNING:  Sports: Could not get presets icon presets/sport/soccer.png
ERROR: Failed to locate image 'presets/sightseeing.png'
WARNING:  Tourism: Could not get presets icon presets/sightseeing.png
ERROR: Failed to locate image 'presets/equestrian.png'
WARNING:  Trail Riding Station: Could not get presets icon presets/equestrian.png
ERROR: Failed to locate image 'presets/works.png'
WARNING:  Man Made: Could not get presets icon presets/works.png

The only preset that I have enabled is https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1 (I am unsure if the missing icons are from NewTags or from something internal in JOSM)

JOSM is 10710

[Klumbumbus]

Replying to naoliv:

The only preset that I have enabled is https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1 (I am unsure if the missing icons are from NewTags or from something internal in JOSM)

JOSM is 10710

This is already fixed. It takes up to 10 days until you get the update in your JOSM. To force an update, see https://josm.openstreetmap.de/wiki/Presets#UpdatingpresetsinJOSM

[naoliv]

Right. Thanks!