Modify ↓
#13208 closed defect (fixed)
[Patch] Use real string for Concatenation
Reported by: | michael2402 | Owned by: | Don-vip |
---|---|---|---|
Priority: | normal | Milestone: | 16.07 |
Component: | Core | Version: | |
Keywords: | gsoc-core regression | Cc: | Don-vip, bastiK, stoecker |
Description (last modified by )
There were too many notes on that layer because int + char is a normal addition.
Caused by [8846]
@Don-vip
is there a special reason you are replacing one character strings with single character values? I found 445 more potential issues like this by searching for '.'\s*\+|\+\s*'.'
Attachments (1)
Change History (9)
by , 8 years ago
Attachment: | patch-fix-char-concat.patch added |
---|
comment:1 by , 8 years ago
Summary: | [Patch] Use real string for Concatination → [Patch] Use real string for Concatenation |
---|
comment:2 by , 8 years ago
Description: | modified (diff) |
---|---|
Keywords: | regression added |
Owner: | changed from | to
comment:3 by , 8 years ago
comment:5 by , 8 years ago
But that string seems incorrect for proper translation. This is not how you produce a plural form. It should probably use trn().
Note:
See TracTickets
for help on using tickets.
This is a minor performance improvement, but I should have been more careful/add more unit tests. There was several other regressions I fixed since this commit.