[Patch] Use a new bug report dialog.

[michael2402]

See #12805

The new window is displayed directly to the user. There is no confirmation message before displaying it.

In expert mode, the stack trace and options to change it are displayed. In non-expert mode, the user has the option to file a bug report, update JOSM or ignore the error.

Plugin error warnings are not changed.

[Klumbumbus]

This looks great.
Two things, which come to my mind: I think the part "Manually report at: http... Copy to clipboard" should be below the "Programmfehler melden" because the "automatic" bug report is preffered. Maybe also the debug information could be moved below "Programmfehler melden". So the order would be:

• Is JOSM up to date?
• Send bug report
• debug information
• manually report
• Weitere Fehlermeldungen für diese Sitzung unterdrücken

This seems more logic to me.

The checkbox "Include all stack traces." should be checked by default. (Maybe it is, I just looked at your screenshot.)

[michael2402]

The checkbox "Include all stack traces." is checked for all exceptions that indicate that multiple threads are involved (e.g. ConcurrentModificationException) and adds all stack traces to the report (which is just a lot of idle threads in most cases). The stack trace of the current thread is always included. To avoid confusion and a lot of needless data, I disabled it by default.

Changing the order is a good idea, I'll update the patch.

[Klumbumbus]

Replying to michael2402:

The stack trace of the current thread is always included. To avoid confusion and a lot of needless data, I disabled it by default.

OK, that sounds reasonable.

[Don-vip]

does not apply cleanly:

• lambda in BugReportSender is already here
• compilation error in BugReportExceptionHandlerTest

[Don-vip]

In 10649/josm:

fix #13193 - Use a new bug report dialog (patch by michael2402) - gsoc-core