Modify

Opened 3 years ago

Closed 3 years ago

#13193 closed enhancement (fixed)

[Patch] Use a new bug report dialog.

Reported by: michael2402 Owned by: team
Priority: normal Milestone: 16.07
Component: Core bugreport Version:
Keywords: gsoc-core Cc: Don-vip, bastiK, stoecker

Description (last modified by michael2402)

See #12805

The new window is displayed directly to the user. There is no confirmation message before displaying it.

In expert mode, the stack trace and options to change it are displayed. In non-expert mode, the user has the option to file a bug report, update JOSM or ignore the error.

Plugin error warnings are not changed.


Attachments (4)

josm-bug-report-13193.png (59.2 KB) - added by michael2402 3 years ago.
patch-bug-report-dialog.patch (25.7 KB) - added by michael2402 3 years ago.
patch-fix-13193.patch (23.8 KB) - added by michael2402 3 years ago.
patch-fix-13193.2.patch (24.8 KB) - added by michael2402 3 years ago.

Download all attachments as: .zip

Change History (11)

Changed 3 years ago by michael2402

Attachment: josm-bug-report-13193.png added

comment:1 Changed 3 years ago by michael2402

Description: modified (diff)

comment:2 Changed 3 years ago by Klumbumbus

This looks great.
Two things, which come to my mind: I think the part "Manually report at: http... Copy to clipboard" should be below the "Programmfehler melden" because the "automatic" bug report is preffered. Maybe also the debug information could be moved below "Programmfehler melden". So the order would be:

  • Is JOSM up to date?
  • Send bug report
  • debug information
  • manually report
  • Weitere Fehlermeldungen für diese Sitzung unterdrücken

This seems more logic to me.

The checkbox "Include all stack traces." should be checked by default. (Maybe it is, I just looked at your screenshot.)

Last edited 3 years ago by Klumbumbus (previous) (diff)

comment:3 Changed 3 years ago by michael2402

The checkbox "Include all stack traces." is checked for all exceptions that indicate that multiple threads are involved (e.g. ConcurrentModificationException) and adds all stack traces to the report (which is just a lot of idle threads in most cases). The stack trace of the current thread is always included. To avoid confusion and a lot of needless data, I disabled it by default.

Changing the order is a good idea, I'll update the patch.

comment:4 in reply to:  3 Changed 3 years ago by Klumbumbus

Replying to michael2402:

The stack trace of the current thread is always included. To avoid confusion and a lot of needless data, I disabled it by default.

OK, that sounds reasonable.

Changed 3 years ago by michael2402

comment:5 Changed 3 years ago by Don-vip

Owner: changed from team to michael2402
Status: newneedinfo

does not apply cleanly:

  • lambda in BugReportSender is already here
  • compilation error in BugReportExceptionHandlerTest

Changed 3 years ago by michael2402

Attachment: patch-fix-13193.patch added

comment:6 Changed 3 years ago by michael2402

Owner: changed from michael2402 to team
Status: needinfonew

Changed 3 years ago by michael2402

Attachment: patch-fix-13193.2.patch added

comment:7 Changed 3 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 10649/josm:

fix #13193 - Use a new bug report dialog (patch by michael2402) - gsoc-core

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.