Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#13191 closed enhancement (fixed)

[Patch] Documentation and migration to java 8 of preset code.

Reported by: michael2402 Owned by: team
Priority: normal Milestone: 16.07
Component: Core Version:
Keywords: gsoc-core java8 Cc: Don-vip, bastiK, stoecker

Description

While going through the preset code I documented some methods to save others the work to figure out what they mean.

I also migrated some parts of the code to java 8 (use lambdas, new predicates, stream.filter().findFist(), ...)

Attachments (1)

patch-java8-presets.patch (24.5 KB) - added by michael2402 3 years ago.

Download all attachments as: .zip

Change History (5)

Changed 3 years ago by michael2402

Attachment: patch-java8-presets.patch added

comment:1 Changed 3 years ago by stoecker

Small Notes:

  • TaggingPreset: "The icon name that was used for this preset." -> "assigned to" instead of "was used", that's used by the XML parser.
  • For KeyedItem "Usage information on a" - a what?

comment:2 Changed 3 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 10590/josm:

see #11390, fix #13191 - Documentation and migration to java 8 of preset code (patch by michael2402) - gsoc-core

comment:3 Changed 3 years ago by Don-vip

In 10591/josm:

see #13191 - fix typos - gsoc-core

comment:4 in reply to:  1 Changed 3 years ago by michael2402

Replying to stoecker:

Small Notes:

  • TaggingPreset: "The icon name that was used for this preset." -> "assigned to" instead of "was used", that's used by the XML parser.
  • For KeyedItem "Usage information on a" - a what?

Thanks for clarifying/fixing that.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.