[Patch] Use invalidation event instead of isChanged()

[michael2402]

Make the MapView trace the source of invalidation events and thus make isChanged() obsolete.

[Don-vip]

does not apply cleanly on top of r10576

[michael2402]

I'd suggest to leave this for 16.08. I'm working on the TileSource layers and will split the patch for them.

[michael2402]

I attached a new file compatible to the current source status.

[Don-vip]

The method Layer.isChanged() is deprecated but still used in MapView.paint()?

[michael2402]

Yes. Layers that still implement it (plugins) will use it to tell the MapView that they have been changed. This is why the MapView still uses it in addition to the invalidation events.

[Don-vip]

OK. I'd prefer to see the two TODOs implemented before merging it, I fear the absence of delays to be problematic.

[michael2402]

The absence worked for years for me.

repaint(100) will repaint after at most 100ms. Internally it triggers the long form of the JComponent#repaint method which ​ignores that parameter.

But I added a timer any way ;-)

[Don-vip]

In 10809/josm:

fix #13175 - Use invalidation event instead of isChanged() (patch by michael2402) - gsoc-core

[simon04]

In 11071/josm:

see #13175 - Document deprecated method usage

[michael2402]

In 12170/josm:

"See #13175, see #14120: Remove isChanged() method call in map view - all layers should invalidate correctly now."