#13172 closed enhancement (fixed)
[Patch] Move ImageryLayer.d[xy] to the settings
| Reported by: | michael2402 | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 16.07 |
| Component: | Core imagery | Version: | |
| Keywords: | gsoc-core | Cc: | Don-vip, bastiK, stoecker |
Description
The display settings object can hold those values. This allows us to store the displacement in a more central place.
I store the displacement as EastNort, this makes using it easier.
This introduces some @deprecated warnings which I intend to fix individually by e.g. moving the OffsetAction to a new file and extracting the paint code.
Attachments (1)
Change History (7)
Changed 7 years ago by
| Attachment: | patch-mapview-extract-imagery-preferences.patch added |
|---|
comment:1 Changed 7 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 Changed 6 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
There are deprecations in ImageryLayer and AbstractTileSourceLayer (not reported by the compiler: setOffset, getDx, getDy). The offset handling hangs awkwardly between both classes.
comment:4 Changed 6 years ago by
| Milestone: | 16.07 → 17.05 |
|---|
comment:5 Changed 6 years ago by
| Milestone: | 17.05 → 16.07 |
|---|---|
| Resolution: | → fixed |
| Status: | reopened → closed |
I already created #14120 for this, and waiting for its correction.
comment:6 Changed 6 years ago by
I would really love to have all this handling in the settings: You should be able to query the settings for a offset and they respond with it. So you should never need to access the layer directly. That way, the imagery settings handle all stored data.
In 10571/josm: