Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#13172 closed enhancement (fixed)

[Patch] Move ImageryLayer.d[xy] to the settings

Reported by: michael2402 Owned by: team
Priority: normal Milestone: 16.07
Component: Core imagery Version:
Keywords: gsoc-core Cc: Don-vip, bastiK, stoecker


The display settings object can hold those values. This allows us to store the displacement in a more central place.

I store the displacement as EastNort, this makes using it easier.

This introduces some @deprecated warnings which I intend to fix individually by e.g. moving the OffsetAction to a new file and extracting the paint code.

Attachments (1)

patch-mapview-extract-imagery-preferences.patch (21.9 KB) - added by michael2402 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by michael2402

comment:1 Changed 7 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 10571/josm:

fix #13172 - Move ImageryLayer.d[xy] to the settings (patch by michael2402) - gsoc-core

comment:2 Changed 7 years ago by Don-vip

In 10603/josm:

see #13172 - fix javadoc

comment:3 Changed 6 years ago by bastiK

Resolution: fixed
Status: closedreopened

There are deprecations in ImageryLayer and AbstractTileSourceLayer (not reported by the compiler: setOffset, getDx, getDy). The offset handling hangs awkwardly between both classes.

comment:4 Changed 6 years ago by bastiK

Milestone: 16.0717.05

comment:5 Changed 6 years ago by Don-vip

Milestone: 17.0516.07
Resolution: fixed
Status: reopenedclosed

I already created #14120 for this, and waiting for its correction.

comment:6 Changed 6 years ago by michael2402

I would really love to have all this handling in the settings: You should be able to query the settings for a offset and they respond with it. So you should never need to access the layer directly. That way, the imagery settings handle all stored data.

Last edited 6 years ago by michael2402 (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.