Opened 9 years ago

Last modified 8 years ago

#13158 closed defect

icons are displayed different — at Version 15

Reported by: Klumbumbus Owned by: Don-vip
Priority: normal Milestone: 16.07
Component: Core Version:
Keywords: template_report regression Cc: bastiK, stoecker, strump

Description (last modified by Klumbumbus)

The display of all office icons and the icon for highway=pedestrian (maybe more) changed their appearance (blue and grey bodies turned into black bodies)
This seems to be a regression of #9995.
r10504 is ok while r10505 is not ok for me (while always having set gui.scale to 1)

With current latest r10533 the body is always black (with gui.scale 1, 1.0 or 0).

screen is 1680*1050 22" (standard resolution)


URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-07-15 19:08:39 +0200 (Fri, 15 Jul 2016)
Build-Date:2016-07-16 01:32:16
Revision:10533
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10533 de) Windows 7 32-Bit
Memory Usage: 247 MB / 742 MB (106 MB allocated, but free)
Java version: 1.8.0_91-b14, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest-bla.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,768m, -Djnlpx.splashport=54281, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Dataset consistency test: No problems found

Plugins:
- AddrInterpolation (32584)
- DirectDownload (32442)
- DirectUpload (32329)
- HouseNumberTaggingTool (32584)
- Mapillary (32639)
- OpeningHoursEditor (32583)
- Tracer2 (32474)
- apache-commons (32584)
- apache-http (32584)
- buildings_tools (32639)
- editgpx (32485)
- imagery_offset_db (32528)
- log4j (32309)
- measurement (32454)
- photo_geotagging (32392)
- photoadjust (32584)
- pt_assistant (32656)
- reverter (32584)
- tag2link (32326)
- tagging-preset-tester (32584)
- terracer (32426)
- todo (29154)
- turnlanes-tagging (1468266519)
- turnrestrictions (32629)
- undelete (32584)
- utilsplugin2 (32584)
- wikipedia (32654)

Tagging presets:
- D:\<user.name>\OSM\JOSMSVN\data\defaultpresets.xml
- D:\<user.name>\OSM\TestNew\newpresets.xml
- http://zibi.openstreetmap.org.pl/kendzi/k/Simple3dPreset/s3db-preset.zip
- https://josm.openstreetmap.de/josmfile?page=Presets/AdvertisingPreset&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/StolpersteineLight&zip=1

Map paint styles:
- D:\<user.name>\OSM\JOSMSVN\styles\standard\elemstyles.mapcss
- D:\<user.name>\OSM\TestNew\newicons.mapcss
- D:\<user.name>\OSM\eigene styles\PriorityRoad\PriorityRoad_1.0.mapcss
- D:\<user.name>\OSM\eigene styles\SpecificBuildingValues\SpecificBuildingValues.mapcss
- D:\<user.name>\OSM\eigene styles\Tourenplanung.mapcss
- D:\<user.name>\OSM\eigene styles\area-symbol.zip
- D:\<user.name>\OSM\patches\old MPs\dataquality.mapcss
- http://www.freietonne.de/ft_icons/josm/FreieTonne_rules_presets_zip.php
- http://www.openrailwaymap.org/styles/standard.mapcss
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/AdvertisingStyle&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/DestinationSignRelation&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/HiDPISupport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Incline&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lit&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LitObjects&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ShowID&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/sac_scale&zip=1
- https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.mapcss

Validator rules:
- D:\<user.name>\OSM\TestNew\new.validator.mapcss
- https://raw.githubusercontent.com/stefan-a-bauer/josm-validators/master/mtb.validator.mapcss

Last errors/warnings:
- W: Datei <josm.cache>\tiles\TMS_BLOCK.key kann nicht gelöscht werden
- W: Datei <josm.cache>\tiles\TMS_BLOCK.data kann nicht gelöscht werden
- W: Datei <josm.cache>\tiles\TMS_INDEX.key kann nicht gelöscht werden
- W: Datei <josm.cache>\tiles\TMS_INDEX.data kann nicht gelöscht werden
- W: Datei <josm.cache>\tiles\TMS_INDEX_v2.key kann nicht gelöscht werden
- W: Datei <josm.cache>\tiles\TMS_INDEX_v2.data kann nicht gelöscht werden
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$SelectAction@19d1bf3
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$AddAction@1bd2843
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$PassAction@26faa1
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$MarkAction@e7e794

Change History (20)

by Klumbumbus, 9 years ago

Attachment: black_body.png added

comment:1 by Klumbumbus, 9 years ago

Description: modified (diff)

comment:2 by Klumbumbus, 9 years ago

Description: modified (diff)

comment:3 by stoecker, 9 years ago

Owner: changed from team to Klumbumbus
Status: newneedinfo

That must have another reason. Tested here with most recent and they are blue. Also I can't think of a single change that could produce such an effect.

Can you check again if there is a setting or something else which does really produce this effect?

comment:4 by Klumbumbus, 9 years ago

I just deleted preferences.xml so it created a new one. Same problem.

comment:5 by stoecker, 9 years ago

Someone else who can reproduce?

comment:6 by Don-vip, 9 years ago

this looks like caused by the server upgrade and the need to rebuild svgcleaner from sources. Only official jars are concerned, not SVN ones.

comment:7 by Don-vip, 9 years ago

As svgcleaner seems unmaintained, I'll try to switch to https://github.com/svg/svgo

comment:8 by Don-vip, 9 years ago

Owner: changed from Klumbumbus to Don-vip
Status: needinfoassigned

comment:9 by Klumbumbus, 9 years ago

Replying to Don-vip:

this looks like caused by the server upgrade and the need to rebuild svgcleaner from sources. Only official jars are concerned, not SVN ones.

That sounds more likely.

  • josm-custom.jar from jenkins are ok
  • josm-testet.jar (10526) from josm download is not ok
  • josm-latest.jar (10547) from josm download is not ok
  • josm-latest.jnlp (10547) from josm download is not ok

comment:10 by stoecker, 9 years ago

I tried svgo before. That's not really usable.

by stoecker, 9 years ago

Attachment: notary_10504.svg added

svgcleaner in 10504 (added line breaks)

by stoecker, 9 years ago

Attachment: notary_10505.svg added

svgcleaner in 10505 (added line breaks)

by stoecker, 9 years ago

Attachment: notary_10505_fixed.svg added

svgcleaner in 10504 (added line breaks) - error fixed

comment:11 by stoecker, 9 years ago

The error is a missing fill in a path:

  • .svg

    old new  
    1111<path d="m7 1042.36h1v1h-1z"/>
    1212<path d="m2 1044.36h1v1h-1z"/>
    1313</g>
    14 <path d="m11.03 1039.36c-.571 0-1.031.536-1.031 1.203v.685c0 .013 0 .026 0 .039v4.073c-.009.751.963.751.954 0v-3.958h.491v10.235c-.012.966 1.238.966 1.226 0v-6.278h.607v6.278c-.012.966 1.238.966 1.226 0v-10.235h.541v3.958c-.009.751.963.751.954 0v-4.797c0-.666-.461-1.202-1.032-1.202z"/>
     14<path d="m11.03 1039.36c-.571 0-1.031.536-1.031 1.203v.685c0 .013 0 .026 0 .039v4.073c-.009.751.963.751.954 0v-3.958h.491v10.235c-.012.966 1.238.966 1.226 0v-6.278h.607v6.278c-.012.966 1.238.966 1.226 0v-10.235h.541v3.958c-.009.751.963.751.954 0v-4.797c0-.666-.461-1.202-1.032-1.202z" fill="#3771c8"/>
    1515</g>
    1616<ellipse fill="#3771c8" cx="13" cy="1037.57" rx="1.204" ry="1.204"/>
    1717<g color-rendering="auto" color-interpolation-filters="linearRGB" shape-rendering="auto" image-rendering="auto" text-rendering="auto" color-interpolation="sRGB" color="#000">

Original: Uncleaned
10504: svgcleaner in 10504 (added line breaks)
10505: svgcleaner in 10505 (added line breaks)
10505 fixed: svgcleaner in 10504 (added line breaks) - error fixed

What source did you use to compile the tool? Is it really unmaintained? It improved a lot compared to the version we had before!

Very likely we can simply turn of the option which causes this problem or we fix the issue.

Last edited 9 years ago by Klumbumbus (previous) (diff)

comment:12 by stoecker, 9 years ago

5 months ago does not look unmaintained for me: https://github.com/RazrFalcon/SVGCleaner

comment:13 by stoecker, 9 years ago

ATM you should use release 0.6.2 instead of latest and we should report this issue.

by stoecker, 9 years ago

Attachment: notary.svg added

Uncleaned

comment:15 by Klumbumbus, 9 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.