Modify ↓

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#13157 closed defect (fixed)

[Patch] Make DateUtilsTest not time out on some time zones

Reported by: michael2402 Owned by: team
Priority: normal Milestone: 16.07
Component: Unit tests Version:
Keywords: gsoc-core Cc: Don-vip, bastiK, stoecker

Description (last modified by michael2402)

The junit timeout task seems to have problems with the timeout when switching time zones.

We have two possible solutions:

  1. Use our own timeout (patch attached, ​before, ​after)
  2. Don't use a timeout for the date tests.

Attachments (2)

patch-fix-13159.patch​ (1.1 KB) - added by michael2402 7 years ago.
patch-test-fix-dateutils-timeout.patch​ (6.1 KB) - added by michael2402 7 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by michael2402

Description: modified (diff)

comment:2 Changed 7 years ago by Don-vip

if the test is no subject to timeout, solution 2 might be better.

comment:3 Changed 7 years ago by Don-vip

Resolution: → fixed
Status: new → closed

In 10563/josm:

fix #13157 - Make DateUtilsTest not time out on some time zones - gsoc-core

Changed 7 years ago by michael2402

Attachment: patch-fix-13159.patch​ added

Changed 7 years ago by michael2402

Attachment: patch-test-fix-dateutils-timeout.patch​ added

comment:4 Changed 7 years ago by michael2402

Resolution: fixed
Status: closed → reopened

Ignore the 13159 fix ;-)

There are other tests that rely on time zone changes.

ExifReaderTest is the only other one that uses the test rules. The patch applies against the old version with [10563] reverted.

comment:5 Changed 7 years ago by Don-vip

Resolution: → fixed
Status: reopened → closed

In 10569/josm:

fix #13157 - Make DateUtilsTest not time out on some time zones (patch by michael2402) - gsoc-core

comment:6 Changed 7 years ago by michael2402

Nice.

First time that all unit tests pass on openjdk8 (except for Mac OS, which I ignored):

​https://travis-ci.org/michaelzangl/josm/builds/145957719

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.