Modify

Opened 9 years ago

Closed 7 years ago

Last modified 2 years ago

#13153 closed enhancement (fixed)

Should not warn to upload/save "modified" layers with 0 objects

Reported by: naoliv Owned by: team
Priority: minor Milestone: 17.11
Component: Core Version:
Keywords: api upload Cc:

Description

Sometimes I create a temporary layer to do some testing and then delete everything from it (but I leave the layer there).
But when closing JOSM or trying to delete only this layer JOSM says that there are modifications in this layer (while in fact we have no objects there).
If we ask to apply the upload action before deleting the layer we can see that it will create an empty changeset.

To test:

  • create a layer
  • insert a node
  • delete the node
  • delete the layer

I guess that JOSM should ignore this empty layer and not offer to upload/save it.

JOSM

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-07-13 23:20:15 +0200 (Wed, 13 Jul 2016)
Build-Date:2016-07-14 01:31:48
Revision:10531
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10531 pt_BR) Linux Debian GNU/Linux testing (stretch)
Memory Usage: 538 MB / 10206 MB (136 MB allocated, but free)
Java version: 1.8.0_91-8u91-b14-3-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Plugins:
- Create_grid_of_ways (32440)
- ImportImagePlugin (32584)
- OpeningHoursEditor (32583)
- PicLayer (32495)
- RoadSigns (32584)
- SimplifyArea (32517)
- apache-commons (32584)
- buildings_tools (32639)
- conflation (0.2.0)
- contourmerge (1014)
- download_along (32535)
- editgpx (32485)
- ejml (32639)
- geojson (42)
- geotools (32584)
- importvec (32490)
- indoorhelper (32637)
- jts (32539)
- log4j (32309)
- measurement (32454)
- merge-overlap (32471)
- opendata (32584)
- pbf (32584)
- pdfimport (32584)
- poly (32584)
- reverter (32584)
- scripting (30723)
- todo (29154)
- turnrestrictions (32629)
- undelete (32584)
- utilsplugin2 (32584)

Attachments (0)

Change History (3)

comment:1 by Don-vip, 7 years ago

Resolution: fixed
Status: newclosed

In 13161/josm:

fix #13153 - Should not warn to upload/save "modified" layers with 0 objects

comment:2 by Don-vip, 7 years ago

Keywords: api upload added
Milestone: 17.11

comment:3 by taylor.smock, 2 years ago

In 18693/josm:

Fix #22811: Map layer is not dirty after processing OSC that adds one node

The setRequiresUploadToServer(isModified()) calls have been replaced to be
consistent with r13161 (see #13153).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.