#13144 closed enhancement (fixed)
Include sex/gender in hairdresser/barber preset
Reported by: | naoliv | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 16.07 |
Component: | Internal preset | Version: | |
Keywords: | Cc: |
Description
While creating a hairdresser/barber using the preset we only have Name
, Opening Hours
and Wheelchairs
Is it possible to also include the sex/gender like https://wiki.openstreetmap.org/wiki/Tag:shop%3Dhairdresser#Tags_to_use_in_combination says, please?
Options should be "empty", "female", "male", "unisex", in a drop-down box (ie, the user will be able to select only one option and, except for the "empty" one, the selected value will be yes
)
Attachments (0)
Change History (6)
comment:1 by , 9 years ago
Milestone: | → 16.07 |
---|
comment:2 by , 9 years ago
comment:3 by , 9 years ago
patch for the validator rules:
/* #13144 */ *[unisex=yes][female=yes][male!=yes], *[unisex=yes][male=yes][female!=yes] { throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); } *[unisex=yes][female=yes][male=yes] { throwWarning: tr("{0} together with {1} and {2}. Remove {1} and {2}", "{0.tag}", "{1.tag}", "{2.tag}"); fixRemove: "female"; fixRemove: "male"; } *[female=yes][male=yes][!unisex][shop=hairdresser] { /* for toilets male=yes female=yes unisex=no combination is valid */ throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); suggestAlternative: "unisex=yes"; fixRemove: "female"; fixRemove: "male"; fixAdd: "unisex=yes"; }
Has i18n impact. Waiting a bit in case a hotfix for milestone 16.06 is required.
comment:4 by , 9 years ago
I only thought about the case where the user creates a hairdresser/barber using the preset (and I forgot that he can modify it using the preset too).
So indeed, a combobox won't properly fit this.
Replying to naoliv:
This is confusing for the user. In a combobox you expect only one key with different values and not different keys. What should the combobox display if both
male=yes
andfemale=yes
are already tagged and you open the preset?I think the better solution would be check boxes and validation rules.