Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13069 closed defect (fixed)

"Crossing waterways" reported for waterway=stream + waterway=riverbank

Reported by: anonymous Owned by: team
Priority: normal Milestone: 16.07
Component: Core validator Version:
Keywords: template_report waterway Cc:

Description

What steps will reproduce the problem?

  1. Download data from http://www.openstreetmap.org/?mlat=49.19821&mlon=22.42633#map=19/49.19821/22.42633 (or create waterway=riverbank area and crossing waterway=stream way)
  2. Run validator

What is the expected result?

Nothing.

What happens instead?

Validator demands creation of pointless node to stop "Crossing waterways" problem.

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-06-04 17:28:58 +0200 (Sat, 04 Jun 2016)
Build-Date:2016-06-04 15:31:27
Revision:10327
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10327 en) Linux Ubuntu 14.04.4 LTS
Memory Usage: 505 MB / 871 MB (227 MB allocated, but free)
Java version: 1.8.0_91-b14, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Djava.security.policy=file:${JAVA_HOME}/jre/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=${JAVA_HOME}/jre/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=${HOME}/.java/deployment/cache/6.0/56/1ee8cfb8-3780ab59, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=55436, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=${JAVA_HOME}/jre/bin/java, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAC1Eam5scC5hcHBsaWNhdGlvbi5ocmVmPWh0dHBzOi8vam9zbS5vcGVuc3RyZWV0bWFwLmRlL2Rvd25sb2FkL2pvc20uam5scAA=]
Dataset consistency test: No problems found

Plugins:
- OpeningHoursEditor (32158)

Last errors/warnings:
- E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400, Error Header=<You requested too many nodes (limit is 50000). Either request a smaller area, or use planet.osm>, Error Body=<Reading error text failed.>
- E: Bad Request - <html>The OSM server 'api.openstreetmap.org' reported a bad request.<br><br>The area you tried to download is too big or your request was too large.<br>Either request a smaller area or use an export file provided by the OSM community.</html>

Attachments (1)

Selection_012.png (189.9 KB) - added by anonymous 5 years ago.
josm screenshoot of data

Download all attachments as: .zip

Change History (11)

Changed 5 years ago by anonymous

Attachment: Selection_012.png added

josm screenshoot of data

comment:1 Changed 5 years ago by Don-vip

Component: CoreCore validator

comment:2 Changed 5 years ago by Don-vip

Keywords: waterway added

comment:3 Changed 5 years ago by Don-vip

Resolution: wontfix
Status: newclosed

I believe that's the intended behaviour.

comment:4 in reply to:  3 Changed 5 years ago by Klumbumbus

Resolution: wontfix
Status: closedreopened

Replying to Don-vip:

I believe that's the intended behaviour.

I don't think so. I quickly checked Tag:waterway=riverbank and I couldn't find a hint that such nodes a required. The images also don't show nodes at the intersections of the river way and the riverbank. Also I cannot think of a good reason to create such nodes.

comment:5 Changed 5 years ago by Klumbumbus

I just noticed that the warning is disabled if the way is waterway=river. However it should be the same for all other linear waterways. (stream, canal, drain, ditch)

comment:6 Changed 5 years ago by Klumbumbus

would this fix it?

  • CrossingWays.java

     
    8282            if (isCoastline(w1) != isCoastline(w2)) {
    8383                return true;
    8484            }
    85             if ((w1.hasTag(WATERWAY, "river") && w2.hasTag(WATERWAY, "riverbank"))
    86                     || (w2.hasTag(WATERWAY, "river") && w1.hasTag(WATERWAY, "riverbank"))) {
     85            if ((w1.hasTag(WATERWAY, "river", "stream", "canal", "drain", "ditch") && w2.hasTag(WATERWAY, "riverbank"))
     86                    || (w2.hasTag(WATERWAY, "river", "stream", "canal", "drain", "ditch") && w1.hasTag(WATERWAY, "riverbank"))) {
    8787                return true;
    8888            }
    8989            if (isProposedOrAbandoned(w2)) {

comment:7 Changed 5 years ago by Klumbumbus

Milestone: 16.07

comment:8 Changed 5 years ago by Don-vip

Yep you're right :) Congratulations for this Java patch :)

comment:9 Changed 5 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 10528/josm:

fix #13069 - "Crossing waterways" reported for waterway=stream + waterway=riverbank (patch by Klumbumbus)

comment:10 in reply to:  8 Changed 5 years ago by Klumbumbus

Replying to Don-vip:

Yep you're right :) Congratulations for this Java patch :)

Thanks :D

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.