Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12998 closed defect (fixed)

regression: zoom snap to background image is no more automatic active

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 16.06
Component: Core imagery Version:
Keywords: template_report, regression Cc: wiktorn, michael2402

Description

What steps will reproduce the problem?

  1. download some data
  2. add bing imagery

What is the expected result?

zoom should snap to the native resolution of the bing layer

What happens instead?

it does not snap, the black white icon left to the eye icon is not active


URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-06-19 02:15:46 +0200 (Sun, 19 Jun 2016)
Build-Date:2016-06-19 01:34:13
Revision:10422
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10422 de) Windows 7 32-Bit
Memory Usage: 334 MB / 742 MB (170 MB allocated, but free)
Java version: 1.8.0_91-b14, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest-bla.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,768m, -Djnlpx.splashport=64393, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Dataset consistency test: No problems found

Plugins:
- AddrInterpolation (32158)
- DirectDownload (32158)
- DirectUpload (32158)
- HouseNumberTaggingTool (31926)
- Mapillary (32158)
- OpeningHoursEditor (32158)
- Tracer2 (32158)
- apache-commons (32158)
- apache-http (32158)
- buildings_tools (32158)
- editgpx (32263)
- imagery_offset_db (32158)
- log4j (32158)
- measurement (32324)
- photo_geotagging (32158)
- photoadjust (32158)
- reverter (32158)
- tag2link (31923)
- tagging-preset-tester (32158)
- terracer (32158)
- todo (29154)
- turnlanes-tagging (1466175713)
- turnrestrictions (32158)
- undelete (32158)
- utilsplugin2 (32158)
- wikipedia (32182)

Tagging presets:
- D:\<user.name>\OSM\JOSMSVN\data\defaultpresets.xml
- D:\<user.name>\OSM\TestNew\newpresets.xml
- http://zibi.openstreetmap.org.pl/kendzi/k/Simple3dPreset/s3db-preset.zip
- https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/StolpersteineLight&zip=1

Map paint styles:
- D:\<user.name>\OSM\JOSMSVN\styles\standard\elemstyles.mapcss
- D:\<user.name>\OSM\TestNew\newicons.mapcss
- D:\<user.name>\OSM\eigene styles\PriorityRoad\PriorityRoad_1.0.mapcss
- D:\<user.name>\OSM\eigene styles\SpecificBuildingValues\SpecificBuildingValues.mapcss
- D:\<user.name>\OSM\eigene styles\Tourenplanung.mapcss
- D:\<user.name>\OSM\eigene styles\area-symbol.zip
- D:\<user.name>\OSM\patches\old MPs\dataquality.mapcss
- http://www.freietonne.de/ft_icons/josm/FreieTonne_rules_presets_zip.php
- http://www.openrailwaymap.org/styles/standard.mapcss
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/DestinationSignRelation&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/HiDPISupport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lit&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LitObjects&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ShowID&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/sac_scale&zip=1
- https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.mapcss

Validator rules:
- D:\<user.name>\OSM\TestNew\new.validator.mapcss
- https://raw.githubusercontent.com/stefan-a-bauer/josm-validators/master/mtb.validator.mapcss

Last errors/warnings:
- W: Datei <josm.cache>\tiles\WMTS_INDEX.key kann nicht gelöscht werden
- W: Datei <josm.cache>\tiles\WMTS_INDEX.data kann nicht gelöscht werden
- W: Datei <josm.cache>\tiles\WMTS_INDEX_v2.key kann nicht gelöscht werden
- W: Datei <josm.cache>\tiles\WMTS_INDEX_v2.data kann nicht gelöscht werden
- W: Old style SideButton usage for action org.openstreetmap.josm.gui.preferences.server.OsmApiUrlInputPanel$ValidateApiUrlAction@115c605

Attachments (1)

snaptobing.png (3.5 KB) - added by Klumbumbus 3 years ago.

Download all attachments as: .zip

Change History (7)

Changed 3 years ago by Klumbumbus

Attachment: snaptobing.png added

comment:1 Changed 3 years ago by Don-vip

Cc: wiktorn michael2402 added

comment:2 Changed 3 years ago by Don-vip

Milestone: 16.06

comment:3 Changed 3 years ago by wiktorn

@michael2402

We are missing something like this:

  • src/org/openstreetmap/josm/gui/MainFrame.java

    diff --git a/src/org/openstreetmap/josm/gui/MainFrame.java b/src/org/openstreetmap/josm/gui/MainFrame.java
    index 7b5a654..1d687af 100644
    a b  
    2828import org.openstreetmap.josm.gui.layer.LayerManager.LayerRemoveEvent;
    2929import org.openstreetmap.josm.gui.layer.MainLayerManager.ActiveLayerChangeEvent;
    3030import org.openstreetmap.josm.gui.layer.MainLayerManager.ActiveLayerChangeListener;
     31import org.openstreetmap.josm.gui.layer.NativeScaleLayer;
    3132import org.openstreetmap.josm.gui.layer.OsmDataLayer;
    3233import org.openstreetmap.josm.gui.layer.OsmDataLayer.LayerStateChangeListener;
    3334import org.openstreetmap.josm.tools.ImageProvider;
     
    187188                OsmDataLayer osmDataLayer = (OsmDataLayer) e.getAddedLayer();
    188189                osmDataLayer.addLayerStateChangeListener(updateTitleOnLayerStateChange);
    189190            }
     191
     192            if (e.getAddedLayer() instanceof NativeScaleLayer) {
     193               Main.map.mapView.setNativeScaleLayer((NativeScaleLayer) e.getAddedLayer());
     194            }
     195
    190196            e.getAddedLayer().addPropertyChangeListener(updateTitleOnSaveChange);
    191197        }
    192198

I'm not sure if it should go to MainFrame or we should leave it in LayerManager.addLayer()

comment:4 Changed 3 years ago by michael2402

I think that the best place to add this would be the MapView itself.

comment:5 Changed 3 years ago by wiktorn

Resolution: fixed
Status: newclosed

In 10440/josm:

Restore call to setNativeScaleLayer incidentally removed during LayerManager introduction.

Closes: #12998

comment:6 in reply to:  4 Changed 3 years ago by wiktorn

Replying to michael2402:

I think that the best place to add this would be the MapView itself.

Good point. I've missed that MapView is also LayerChangeListener

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.