Modify

Opened 3 years ago

Closed 3 years ago

#12959 closed enhancement (fixed)

Move state changes to MapViewState class

Reported by: michael2402 Owned by: team
Priority: normal Milestone: 16.06
Component: Core mappaint Version:
Keywords: gsoc-core Cc: Don-vip, bastiK, stoecker

Description

The MapViewState class handles state changes for now.

The updateLocationState() method is called too often and coordinate conversion for painting is creating one more intermediate object. I'll optimize this later when working on the map view painting.

Attachments (2)

patch-mapview-add-state-getter.patch (30.5 KB) - added by michael2402 3 years ago.
patch-fix-12959-tests.patch (2.8 KB) - added by michael2402 3 years ago.

Download all attachments as: .zip

Change History (10)

Changed 3 years ago by michael2402

comment:1 Changed 3 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 10375/josm:

fix #12959 - Move state changes to MapViewState class (patch by michael2402) - gscore-core + checkstyle fixes

comment:2 Changed 3 years ago by Don-vip

Milestone: 16.06

comment:3 Changed 3 years ago by Don-vip

In 10381/josm:

see #12959 - fix javadoc warning

comment:4 Changed 3 years ago by Don-vip

Resolution: fixed
Status: closedreopened

comment:5 Changed 3 years ago by Don-vip

I didn't notice the unit test now relies on constructing a JFrame: that's not possible, all unit tests must run in headless mode. You'll have to find another solution.

comment:6 Changed 3 years ago by Don-vip

Summary: [Patch] Move state changes to MapViewState classMove state changes to MapViewState class

comment:7 Changed 3 years ago by Don-vip

This change causes areas to not be rendered anymore, see #12975

Changed 3 years ago by michael2402

Attachment: patch-fix-12959-tests.patch added

comment:8 Changed 3 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 10405/josm:

fix #12959 - Do not make unit tests rely on JFrame for headless mode (patch by michael2402) - gsoc-core

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.