[Patch] Move title management and main frame layout to new class.

[michael2402]

Work for #12925

Create a new MainFrame class to:

• Move the refreshTitle() out of MapView
• Move the window icon code there
• Move maximized check there
• Add a new reference to the main window to MainApplication
• Restructure some hooks to resolve dependencies during startup.
• Main() does not do the work in the constructor any more and uses initialize():

To be done later:

• Clean up Icon code
• Re-enable the test that checks if the window size parameter works (does not work now since we cannot construct the frame in headless mode)

[stoecker]

Hmm, are the two classes Main/MainApplication still necessary? I think that was mainly made due to the applet functionality, which has been dropped inbetween. Maybe that can be unified as well if you already start working at it?

[michael2402]

Currently, they are a bit mixed up and unstructured. I would suggest to keep them:

• Leave all public stuff in Main (global fields, ...)
• Move the startup code and other lifecycle things to MainApplication.

MainApplication might not even need to extend Main any more - but at the moment, the whole code has complicated dependencies and the order in which components are initialized (often in constructor / static blocks) is enforced by the order in which classes are loaded.

[stoecker]

Vincent, bastiK: If ok (I think so), please apply. I can't today.

[Don-vip]

In 10340/josm:

fix #12927 - Move title management and main frame layout to new class (patch by michael2402) - gsoc-core

[Don-vip]

looks ok I just fixed a typo (initalize => initialize)

[michael2402]

Thanks for the typo - didn't see that.