Issue with plugin cadastre-fr

[jeremy.hetzel@…]

What steps will reproduce the problem?

1. each launch of an action from the plug-in cadastre-fr

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-05-02 10:23:17 +0200 (Mon, 02 May 2016)
Build-Date:2016-05-03 01:31:45
Revision:10168
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10168 fr) Windows 7 64-Bit
Memory Usage: 153 MB / 247 MB (49 MB allocated, but free)
Java version: 1.8.0_60-b27, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\56\1ee8cfb8-34ba9eb4, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=49244, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAC1Eam5scC5hcHBsaWNhdGlvbi5ocmVmPWh0dHBzOi8vam9zbS5vcGVuc3RyZWV0bWFwLmRlL2Rvd25sb2FkL2pvc20uam5scAA=]
Dataset consistency test: No problems found

Plugins:
- apache-commons (32158)
- cadastre-fr (32165)
- ejml (32158)
- geotools (31895)
- jts (31906)
- opendata (32158)
- utilsplugin2 (32158)

Last errors/warnings:
- E: java.lang.StringIndexOutOfBoundsException: String index out of range: -1

java.lang.StringIndexOutOfBoundsException: String index out of range: -1
	at java.lang.String.substring(Unknown Source)
	at cadastre_fr.CadastreInterface.getCookie(CadastreInterface.java:124)
	at cadastre_fr.CadastreInterface.retrieveInterface(CadastreInterface.java:81)
	at cadastre_fr.DownloadWMSVectorImage.realRun(DownloadWMSVectorImage.java:33)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:93)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:161)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

[Don-vip]

Ticket #12888 has been marked as a duplicate of this ticket.

[Don-vip]

Robustness added in [o32205:32206] but I don't know why the plugin doesn't work anymore

[Tyndare]

Could it be related to the new CSRF_TOKEN needed to acces the cadastee web site ?

See a fix for another app:
​https://github.com/osm-fr/export-cadastre/commit/5f143d0983b0f6457688df80086e7f34e0f94ca6

[Don-vip]

Thanks! It was partly because of that. I have fixed the plugin in [o32212].

[Yves Autran <yves.autran@…>]

Great !
Many thanks for fixing this issue so fast.
Yves