using the validator autofix when tags were changed after the validation process results in an incorrect autofix

[josm@…]

What steps will reproduce the problem?

1. Enter a tag which can be written nicer (here Off instead of off): opening_hours=Mo-Fr 08:30-20:00; PH Off
2. Start the Validator
3. Change the Value to Mo-Su 08:30-20:00; PH Off
4. Select "correct the value" from the Validator

What is the expected result?

The resulting Tag should be: Mo-Su 08:30-20:00; PH off

What happens instead?

The Tag corrects the old value: Mo-Fr 08:30-20:00; PH off

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-04-26 22:05:51 +0200 (Tue, 26 Apr 2016)
Build-Date:2016-04-27 01:31:55
Revision:10159
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10159 de) Windows 7 64-Bit
Memory Usage: 151 MB / 247 MB (57 MB allocated, but free)
Java version: 1.8.0_91-b14, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files (x86)\josm-latest.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=63253, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Dataset consistency test: No problems found

Plugins:
- FastDraw (31895)
- FixAddresses (31772)
- Mapillary (32040)
- OpeningHoursEditor (31772)
- PicLayer (31895)
- RoadSigns (31895)
- apache-commons (31895)
- apache-http (31895)
- buildings_tools (31895)
- imagery_offset_db (32046)
- junctionchecking (31772)
- lakewalker (31772)
- log4j (31895)
- public_transport (31895)
- reltoolbox (31895)
- reverter (32005)
- terracer (31895)
- todo (29154)
- undelete (31895)
- utilsplugin2 (32099)
- waydownloader (31772)
- wikipedia (32114)

Tagging presets:
- http://dev.openseamap.org/josm/Presets_Hafen.xml
- http://michreichert.de/osm/wochenaufgabe/wa0607-apotheken/apotheken.xml
- http://osm.michis-pla.net/presets/observatory.xml
- http://osm.sebastian-klemm.eu/josm/josm-preset_parkinglane.xml
- http://osmtools.de/josm/steps.xml
- http://somewhere.dk/email/josm/tower/tower.xml
- http://zibi.openstreetmap.org.pl/kendzi/k/Simple3dPreset/s3db-preset.zip
- https://josm.openstreetmap.de/josmfile?page=Presets/BuildingPreset&preset&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/Crafts&preset&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&preset&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/NewParkingFeatures&preset&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/OpenPisteMap&preset&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportOneClick&preset&zip=1
- https://raw.github.com/rurseekatze/OpenRailwayMap/master/josm-presets/de.xml

Map paint styles:
- http://www.openrailwaymap.org/styles/standard.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lit&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleBuildingTags&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleRoofTags&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&style&zip=1
- https://raw.githubusercontent.com/nebulon42/osmic-josm-style/master/osmic.mapcss

Last errors/warnings:
- W:  Phone (Railway): Could not get presets icon phone-32.png
- E: Fehler beim Laden des Bildes 'owner-change.svg'
- W:  Change of Operator: Could not get presets icon owner-change.svg
- E: Fehler beim Laden des Bildes 'styles/standard/health/pharmacy.png'
- W: [NODE, CLOSEDWAY] Pharmacy: Could not get presets icon styles/standard/health/pharmacy.png

[naoliv]

It's not specific to opening_hours, but it happens with anything that offers an autofix.

For example, have one object with power=sub_station and validate it.
Then change it to power=generator and click to fix the outdated sub_station tag. Note how power=generator gets renamed to power=substation

Modified objects after a validation should not be autofixed, if possible.

[Klumbumbus]

Replying to naoliv:

Modified objects after a validation should not be autofixed, if possible.

Or if the object was modified after the validation process the specific validator rule should be executed again to this object when pressing the fix button before performing the autofix.

[Klumbumbus]

typo

[skyper]

typo