Modify

Opened 5 years ago

Closed 5 years ago

#12534 closed enhancement (wontfix)

Additional commas should be permitted after last selector in MapCSS

Reported by: Dakon Owned by: team
Priority: normal Milestone:
Component: Core Version: tested
Keywords: Cc: Klumbumbus

Description

When I look at both grammars linked at http://wiki.openstreetmap.org/wiki/MapCSS/0.2 additional commas are permitted after the last selector and before the definitions, even a comment exists in https://github.com/Gubaer/dart-mapcss/tree/master/grammar that explicitiely allows them.

So this shouldn't raise an error:

way, node, { z-index: 1 }

Attachments (0)

Change History (4)

comment:1 Changed 5 years ago by Klumbumbus

Cc: Klumbumbus added

comment:2 Changed 5 years ago by bastiK

I'm not sure these grammars are authoritative. ;)

One guiding principle for MapCSS is to be like CSS, except if there is a reason not to. The CSS grammar doesn't seem to allow a comma there. Why would this be useful, anyway?

comment:3 Changed 5 years ago by Dakon

I have no real use for this, I just found that mapcss_converter accepts it, JOSM refuses it, and it looks like everything I could find that is close to a standard allows it, so I wanted to get it sorted out.

comment:4 Changed 5 years ago by bastiK

Resolution: wontfix
Status: newclosed
Type: defectenhancement

I think there is nothing wrong with the current behavior in JOSM. Permitting a final comma is fine as well. Please write a patch, or ask someone to write a patch, if you want it changed.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.